This is an archive of the discontinued LLVM Phabricator instance.

Differential D29482

Object: Handle files without a dynamic symbol table.
ClosedPublic

Authored by pcc on Feb 2 2017, 6:21 PM.

Details

Reviewers
• rafael
Commits
rGcce2d8028fe0: Object: Handle files without a dynamic symbol table.
rL294013: Object: Handle files without a dynamic symbol table.

Diff Detail

Event Timeline

pcc created this revision.Feb 2 2017, 6:21 PM
Closed by commit rL294013: Object: Handle files without a dynamic symbol table. (authored by pcc). · Explain WhyFeb 3 2017, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
include/
llvm/
Object/
2 lines
test/
Object/
2 lines

Diff 86930

llvm/include/llvm/Object/ELFObjectFile.h

Show First 20 Lines • Show All 889 Lines • ▼ Show 20 Lines
elf_symbol_iterator ELFObjectFile<ELFT>::dynamic_symbol_begin() const { elf_symbol_iterator ELFObjectFile<ELFT>::dynamic_symbol_begin() const {
DataRefImpl Sym = toDRI(DotDynSymSec, 0); DataRefImpl Sym = toDRI(DotDynSymSec, 0);
return symbol_iterator(SymbolRef(Sym, this)); return symbol_iterator(SymbolRef(Sym, this));
} }
template <class ELFT> template <class ELFT>
elf_symbol_iterator ELFObjectFile<ELFT>::dynamic_symbol_end() const { elf_symbol_iterator ELFObjectFile<ELFT>::dynamic_symbol_end() const {
const Elf_Shdr *SymTab = DotDynSymSec; const Elf_Shdr *SymTab = DotDynSymSec;
if (!SymTab)
return dynamic_symbol_begin();
DataRefImpl Sym = toDRI(SymTab, SymTab->sh_size / sizeof(Elf_Sym)); DataRefImpl Sym = toDRI(SymTab, SymTab->sh_size / sizeof(Elf_Sym));
return basic_symbol_iterator(SymbolRef(Sym, this)); return basic_symbol_iterator(SymbolRef(Sym, this));
} }
template <class ELFT> template <class ELFT>
section_iterator ELFObjectFile<ELFT>::section_begin() const { section_iterator ELFObjectFile<ELFT>::section_begin() const {
auto SectionsOrErr = EF.sections(); auto SectionsOrErr = EF.sections();
if (!SectionsOrErr) if (!SectionsOrErr)
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines

llvm/test/Object/nm-shared-object.test

Show All 23 Lines
RUN: not llvm-nm -D %p/Inputs/weak-global-symbol.macho-i386 2>&1 \ RUN: not llvm-nm -D %p/Inputs/weak-global-symbol.macho-i386 2>&1 \
RUN: | FileCheck %s -check-prefix ERROR RUN: | FileCheck %s -check-prefix ERROR
RUN: not llvm-nm -D %p/Inputs/trivial-object-test.coff-i386 2>&1 \ RUN: not llvm-nm -D %p/Inputs/trivial-object-test.coff-i386 2>&1 \
RUN: | FileCheck %s -check-prefix ERROR RUN: | FileCheck %s -check-prefix ERROR
ERROR: File format has no dynamic symbol table. ERROR: File format has no dynamic symbol table.
RUN: llvm-nm -D %p/Inputs/trivial-object-test.elf-i386 | count 0