This is an archive of the discontinued LLVM Phabricator instance.

Differential D29343

InferAddressSpaces: Avoid double map lookup
ClosedPublic

Authored by arsenm on Jan 31 2017, 12:28 PM.

Details

Reviewers
jlebar

Diff Detail

Event Timeline

arsenm created this revision.Jan 31 2017, 12:28 PM
Herald added a subscriber: wdng. · View Herald TranscriptJan 31 2017, 12:28 PM
jlebar accepted this revision.Jan 31 2017, 12:42 PM
This revision is now accepted and ready to land.Jan 31 2017, 12:42 PM
arsenm closed this revision.Jan 31 2017, 4:01 PM

r293719

Revision Contents

PathSize
lib/
Transforms/
Scalar/
10 lines

Diff 86475

lib/Transforms/Scalar/InferAddressSpaces.cpp

Show First 20 Lines • Show All 585 Lines • ▼ Show 20 Lines
Optional<unsigned> InferAddressSpaces::updateAddressSpace( Optional<unsigned> InferAddressSpaces::updateAddressSpace(
const Value &V, const ValueToAddrSpaceMapTy &InferredAddrSpace) const { const Value &V, const ValueToAddrSpaceMapTy &InferredAddrSpace) const {
assert(InferredAddrSpace.count(&V)); assert(InferredAddrSpace.count(&V));
// The new inferred address space equals the join of the address spaces // The new inferred address space equals the join of the address spaces
// of all its pointer operands. // of all its pointer operands.
unsigned NewAS = UninitializedAddressSpace; unsigned NewAS = UninitializedAddressSpace;
for (Value *PtrOperand : getPointerOperands(V)) { for (Value *PtrOperand : getPointerOperands(V)) {
unsigned OperandAS; auto I = InferredAddrSpace.find(PtrOperand);
if (InferredAddrSpace.count(PtrOperand)) unsigned OperandAS = I != InferredAddrSpace.end() ?
OperandAS = InferredAddrSpace.lookup(PtrOperand); I->second : PtrOperand->getType()->getPointerAddressSpace();
else
OperandAS = PtrOperand->getType()->getPointerAddressSpace();
NewAS = joinAddressSpaces(NewAS, OperandAS);
// join(flat, *) = flat. So we can break if NewAS is already flat. // join(flat, *) = flat. So we can break if NewAS is already flat.
NewAS = joinAddressSpaces(NewAS, OperandAS);
if (NewAS == FlatAddrSpace) if (NewAS == FlatAddrSpace)
break; break;
} }
unsigned OldAS = InferredAddrSpace.lookup(&V); unsigned OldAS = InferredAddrSpace.lookup(&V);
assert(OldAS != FlatAddrSpace); assert(OldAS != FlatAddrSpace);
if (OldAS == NewAS) if (OldAS == NewAS)
return None; return None;
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines