This is an archive of the discontinued LLVM Phabricator instance.

Keep Chromium ObjC column limit at 80 for consistency with C++
ClosedPublic

Authored by danbeam on Jan 31 2017, 10:34 AM.

Details

Reviewers
thakis
Summary

At the moment, all of Chromium's ObjC code is wrapped at 80 columns.

Google's ObjC style recently changed to 100 columns:
https://github.com/llvm-mirror/clang/commit/f57fa8e1d4cb815ab145f01770565f4e4441ca1b

Chromium is likely to want to keep to 80 columns for consistency with C++, but it's not yet super duper clear. This is being decided here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/De-RNhaGozs

However, it is clear that Chromium's presubmit tooling is not yet ready for a change in column limit:
https://bugs.chromium.org/p/chromium/issues/detail?id=686650

Let's keep Chromium ObjC to 80 cols while this is all figured out.

Diff Detail

Event Timeline

danbeam created this revision.Jan 31 2017, 10:34 AM
thakis accepted this revision.Jan 31 2017, 10:38 AM
This revision is now accepted and ready to land.Jan 31 2017, 10:38 AM
thakis closed this revision.Jan 31 2017, 10:53 AM

r293675