This is an archive of the discontinued LLVM Phabricator instance.

Differential D2925

[AArch64]Improper diagnostics about offset range of load/store instructions.
ClosedPublic

Authored by kevin.qin on Mar 3 2014, 2:06 AM.

Details

Reviewers
t.p.northover
Summary

Hi Tim and other reviewers,

LDP for example, its Post-index ASM format in ARMARM is,

32-bit variant (opc = 00)
LDP <St1>, <St2>, [<Xn|SP>], #<imm>
64-bit variant (opc = 01)
LDP <Dt1>, <Dt2>, [<Xn|SP>], #<imm>
128-bit variant (opc = 10)
LDP <Qt1>, <Qt2>, [<Xn|SP>], #<imm>

<imm> 32-bit signed offset: is the immediate offset which defaults to 0 and is a multiple of 4 in the range -256 to 252, with the "imm7" field encoding <imm>/4.
<imm> 64-bit signed offset: is the immediate offset which defaults to 0 and is a multiple of 8 in the range -512 to 504, with the "imm7" field encoding <imm>/8.
<imm> 128-bit signed offset: is the immediate offset which defaults to 0 and is a multiple of 16 in the range -1024 to 1008, with the "imm7" field encoding <imm>/16.

Current diagnostics for 64-bit signed offset is "error: expected integer multiple of 8 in range [-512, 508]", and for 128-bit signed offset is "error: expected integer multiple of 16 in range [-1024, 1016]". Although the ranges are not wrong (504 is the largest multiple of 8 in range [-512, 508], and 1008 is the largest multiple of 16 in range [-1024, 1008]), diagnostics still may get end-user confused. So change them to ARMARM is much easier to understand.

Diff Detail

Event Timeline

t.p.northover accepted this revision.Mar 3 2014, 2:40 AM

Good catch. Looks fine to me.

Cheers.

Tim.

Eugene.Zelenko closed this revision.Oct 3 2016, 5:51 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in rL202775.

Revision Contents

PathSize
lib/
Target/
AArch64/
AsmParser/
4 lines
test/
MC/
AArch64/
64 lines

Diff 7469

lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Context not available.
"expected integer multiple of 4 in range [-256, 252]"); "expected integer multiple of 4 in range [-256, 252]");
case Match_LoadStoreSImm7_8: case Match_LoadStoreSImm7_8:
return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(), return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(),
"expected integer multiple of 8 in range [-512, 508]"); "expected integer multiple of 8 in range [-512, 504]");
case Match_LoadStoreSImm7_16: case Match_LoadStoreSImm7_16:
return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(), return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(),
"expected integer multiple of 16 in range [-1024, 1016]"); "expected integer multiple of 16 in range [-1024, 1008]");
case Match_LoadStoreSImm9: case Match_LoadStoreSImm9:
return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(), return Error(((AArch64Operand*)Operands[ErrorInfo])->getStartLoc(),
"expected integer in range [-256, 255]"); "expected integer in range [-256, 255]");
Context not available.

test/MC/AArch64/basic-a64-diagnostics.s

Context not available.
ldp x2, x5, [sp, #4] ldp x2, x5, [sp, #4]
ldp x5, x6, [x9, #512] ldp x5, x6, [x9, #512]
stp x7, x8, [x10, #-520] stp x7, x8, [x10, #-520]
// CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x2, x5, [sp, #4] // CHECK-ERROR-NEXT: ldp x2, x5, [sp, #4]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x5, x6, [x9, #512] // CHECK-ERROR-NEXT: ldp x5, x6, [x9, #512]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp x7, x8, [x10, #-520] // CHECK-ERROR-NEXT: stp x7, x8, [x10, #-520]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, d4, [xzr] // CHECK-ERROR-NEXT: ldp d3, d4, [xzr]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp d5, d6, [x0, #512] // CHECK-ERROR-NEXT: ldp d5, d6, [x0, #512]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp d7, d8, [x0, #-520] // CHECK-ERROR-NEXT: stp d7, d8, [x0, #-520]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, q2, [sp] // CHECK-ERROR-NEXT: ldp d3, q2, [sp]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q3, q5, [sp, #8] // CHECK-ERROR-NEXT: ldp q3, q5, [sp, #8]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: stp q20, q25, [x5, #1024] // CHECK-ERROR-NEXT: stp q20, q25, [x5, #1024]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q30, q15, [x23, #-1040] // CHECK-ERROR-NEXT: ldp q30, q15, [x23, #-1040]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
ldp x2, x5, [sp], #4 ldp x2, x5, [sp], #4
ldp x5, x6, [x9], #512 ldp x5, x6, [x9], #512
stp x7, x8, [x10], #-520 stp x7, x8, [x10], #-520
// CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x2, x5, [sp], #4 // CHECK-ERROR-NEXT: ldp x2, x5, [sp], #4
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x5, x6, [x9], #512 // CHECK-ERROR-NEXT: ldp x5, x6, [x9], #512
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp x7, x8, [x10], #-520 // CHECK-ERROR-NEXT: stp x7, x8, [x10], #-520
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, d4, [xzr], #0 // CHECK-ERROR-NEXT: ldp d3, d4, [xzr], #0
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp d5, d6, [x0], #512 // CHECK-ERROR-NEXT: ldp d5, d6, [x0], #512
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp d7, d8, [x0], #-520 // CHECK-ERROR-NEXT: stp d7, d8, [x0], #-520
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, q2, [sp], #0 // CHECK-ERROR-NEXT: ldp d3, q2, [sp], #0
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q3, q5, [sp], #8 // CHECK-ERROR-NEXT: ldp q3, q5, [sp], #8
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: stp q20, q25, [x5], #1024 // CHECK-ERROR-NEXT: stp q20, q25, [x5], #1024
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q30, q15, [x23], #-1040 // CHECK-ERROR-NEXT: ldp q30, q15, [x23], #-1040
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
ldp x2, x5, [sp, #4]! ldp x2, x5, [sp, #4]!
ldp x5, x6, [x9, #512]! ldp x5, x6, [x9, #512]!
stp x7, x8, [x10, #-520]! stp x7, x8, [x10, #-520]!
// CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x2, x5, [sp, #4]! // CHECK-ERROR-NEXT: ldp x2, x5, [sp, #4]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp x5, x6, [x9, #512]! // CHECK-ERROR-NEXT: ldp x5, x6, [x9, #512]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp x7, x8, [x10, #-520]! // CHECK-ERROR-NEXT: stp x7, x8, [x10, #-520]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, d4, [xzr, #0]! // CHECK-ERROR-NEXT: ldp d3, d4, [xzr, #0]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldp d5, d6, [x0, #512]! // CHECK-ERROR-NEXT: ldp d5, d6, [x0, #512]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stp d7, d8, [x0, #-520]! // CHECK-ERROR-NEXT: stp d7, d8, [x0, #-520]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldp d3, q2, [sp, #0]! // CHECK-ERROR-NEXT: ldp d3, q2, [sp, #0]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q3, q5, [sp, #8]! // CHECK-ERROR-NEXT: ldp q3, q5, [sp, #8]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: stp q20, q25, [x5, #1024]! // CHECK-ERROR-NEXT: stp q20, q25, [x5, #1024]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldp q30, q15, [x23, #-1040]! // CHECK-ERROR-NEXT: ldp q30, q15, [x23, #-1040]!
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
ldnp x2, x5, [sp, #4] ldnp x2, x5, [sp, #4]
ldnp x5, x6, [x9, #512] ldnp x5, x6, [x9, #512]
stnp x7, x8, [x10, #-520] stnp x7, x8, [x10, #-520]
// CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldnp x2, x5, [sp, #4] // CHECK-ERROR-NEXT: ldnp x2, x5, [sp, #4]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldnp x5, x6, [x9, #512] // CHECK-ERROR-NEXT: ldnp x5, x6, [x9, #512]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stnp x7, x8, [x10, #-520] // CHECK-ERROR-NEXT: stnp x7, x8, [x10, #-520]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldnp d3, d4, [xzr] // CHECK-ERROR-NEXT: ldnp d3, d4, [xzr]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: ldnp d5, d6, [x0, #512] // CHECK-ERROR-NEXT: ldnp d5, d6, [x0, #512]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 508] // CHECK-ERROR-NEXT: error: expected integer multiple of 8 in range [-512, 504]
// CHECK-ERROR-NEXT: stnp d7, d8, [x0, #-520] // CHECK-ERROR-NEXT: stnp d7, d8, [x0, #-520]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.
// CHECK-ERROR: error: invalid operand for instruction // CHECK-ERROR: error: invalid operand for instruction
// CHECK-ERROR-NEXT: ldnp d3, q2, [sp] // CHECK-ERROR-NEXT: ldnp d3, q2, [sp]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldnp q3, q5, [sp, #8] // CHECK-ERROR-NEXT: ldnp q3, q5, [sp, #8]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: stnp q20, q25, [x5, #1024] // CHECK-ERROR-NEXT: stnp q20, q25, [x5, #1024]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
// CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1016] // CHECK-ERROR-NEXT: error: expected integer multiple of 16 in range [-1024, 1008]
// CHECK-ERROR-NEXT: ldnp q30, q15, [x23, #-1040] // CHECK-ERROR-NEXT: ldnp q30, q15, [x23, #-1040]
// CHECK-ERROR-NEXT: ^ // CHECK-ERROR-NEXT: ^
Context not available.