Page MenuHomePhabricator

[scan-build-py] remove batch files
ClosedPublic

Authored by rizsotto.mailinglist on Jan 28 2017, 1:04 AM.

Details

Summary

Removed the .bat files, because they are misleading.

It does look it works, but it works against one file only. When that one file is compiled by the compiler wrapper, it resume the build process. Looks like if you run multiple python processes (on Windows) an exit of one process tears down all python processes. The solution for it is to compile an executable from the python sources (that's what setuptools are doing). This is tested on appveyor.

When the cmake driven installation take place, that shall do the compilation. Until then just delete it, because it might give a false illusion that it works on Windows, but just could cause long debugging hours to whom it wants to run.

Diff Detail

Event Timeline

dcoughlin accepted this revision.Jan 28 2017, 10:32 AM

Sounds reasonable to me.

This revision is now accepted and ready to land.Jan 28 2017, 10:32 AM