Page MenuHomePhabricator

rizsotto.mailinglist (Laszlo Nagy)
User

Projects

User does not belong to any projects.

User Details

User Since
May 8 2015, 2:41 AM (214 w, 3 d)

Recent Activity

Jun 19 2017

rizsotto.mailinglist abandoned D31365: [scan-build-py] compilation module rewrite.

@george.karpenkov thanks for your comments. I totally lost interest to continue this job, due to lack of feedback. Will use your catches, suggestions on my upstream repository. Thanks again!

Jun 19 2017, 11:56 PM

Apr 26 2017

rizsotto.mailinglist added a comment to D31365: [scan-build-py] compilation module rewrite.

ping

Apr 26 2017, 4:31 AM
rizsotto.mailinglist abandoned D31844: [scan-build-py] intercepted executions persisted in JSON files.
Apr 26 2017, 4:29 AM

Apr 18 2017

rizsotto.mailinglist added a comment to D31365: [scan-build-py] compilation module rewrite.

ping

Apr 18 2017, 3:00 AM
rizsotto.mailinglist added a comment to D31844: [scan-build-py] intercepted executions persisted in JSON files.

ping

Apr 18 2017, 2:59 AM

Apr 8 2017

rizsotto.mailinglist added a comment to D31844: [scan-build-py] intercepted executions persisted in JSON files.

Realized that these changes are related to environment access simplification. I hope it can be merged together.

Apr 8 2017, 4:08 AM
rizsotto.mailinglist created D31844: [scan-build-py] intercepted executions persisted in JSON files.
Apr 8 2017, 3:54 AM

Apr 7 2017

rizsotto.mailinglist updated the diff for D31365: [scan-build-py] compilation module rewrite.

Fixed review comments.

Apr 7 2017, 5:09 AM

Apr 6 2017

rizsotto.mailinglist added a comment to D31365: [scan-build-py] compilation module rewrite.

I want to store Compilation in set to filter out duplicates. (That requires __hash__ and (__eq__ or __cmp__)) New objects will be created from files, so structural equality is needed. (No chance that reference equality would be enough.)
Thanks for the review, will upload a new diff soon.

Apr 6 2017, 6:26 AM

Apr 4 2017

rizsotto.mailinglist added a comment to D31237: [scan-build-py] merge runner module to analyzer.

ping

Apr 4 2017, 3:59 PM
rizsotto.mailinglist added a comment to D31365: [scan-build-py] compilation module rewrite.

Any other comment guys? Would like to merge this week and continue with other PRs which depends on this.

Apr 4 2017, 3:59 PM

Mar 27 2017

rizsotto.mailinglist added inline comments to D31365: [scan-build-py] compilation module rewrite.
Mar 27 2017, 1:40 AM

Mar 25 2017

rizsotto.mailinglist created D31365: [scan-build-py] compilation module rewrite.
Mar 25 2017, 2:22 AM

Mar 22 2017

rizsotto.mailinglist created D31237: [scan-build-py] merge runner module to analyzer.
Mar 22 2017, 3:38 AM

Mar 21 2017

rizsotto.mailinglist added a comment to D30861: [scan-build-py] reuse command line output parameter for report directory.

Thanks Jonathan!

Mar 21 2017, 3:34 AM
rizsotto.mailinglist abandoned D30974: [CompilationDatabase] remove duplicate elements.

All right, then everything stays the same. :)

Mar 21 2017, 2:30 AM

Mar 20 2017

rizsotto.mailinglist added a comment to D30861: [scan-build-py] reuse command line output parameter for report directory.

Gentle ping. (There are a couple of other change I would be based on this.)

Mar 20 2017, 2:30 AM
rizsotto.mailinglist added a comment to D30862: [scan-build-py] use python tempfile for tempdir.

Thanks for the review Devin!

Mar 20 2017, 2:22 AM

Mar 19 2017

rizsotto.mailinglist updated the diff for D30974: [CompilationDatabase] remove duplicate elements.

Implemented preprocessor flag filtering.

Mar 19 2017, 4:38 AM

Mar 15 2017

rizsotto.mailinglist created D30974: [CompilationDatabase] remove duplicate elements.
Mar 15 2017, 3:05 AM

Mar 11 2017

rizsotto.mailinglist created D30862: [scan-build-py] use python tempfile for tempdir.
Mar 11 2017, 3:27 AM
rizsotto.mailinglist created D30861: [scan-build-py] reuse command line output parameter for report directory.
Mar 11 2017, 3:20 AM

Mar 8 2017

rizsotto.mailinglist added a comment to D30601: [scan-build-py] move argument parsing into separate module.

Thanks Devin. I forgot to add the arguments.py module at the commit, so this does not show it. But made another commit which has it. Sorry.

Mar 8 2017, 1:35 PM
rizsotto.mailinglist updated the diff for D30601: [scan-build-py] move argument parsing into separate module.

fixed review comments.

Mar 8 2017, 2:25 AM
rizsotto.mailinglist added a comment to D30600: [scan-build-py] fix some line separator issues.

Thanks Devin!

Mar 8 2017, 1:41 AM

Mar 6 2017

rizsotto.mailinglist added a comment to D30601: [scan-build-py] move argument parsing into separate module.

Thanks Devin for the comments. I'm happy to have your improvement suggestions crafted, scratched. It helps me to understand what part is debated... See my replies inlined.

Mar 6 2017, 3:44 AM

Mar 5 2017

rizsotto.mailinglist added a comment to D30600: [scan-build-py] fix some line separator issues.

Looks good to me, although please update the comment to be prose and have proper capitalization.

Can I ask a temporary exemption on capitalization? Here's why I'm asking... Currently all pydoc comments are capitalized, but inline ones are not. So, it's kind of consistent this way. (I understand that's not what the project guidelines says.) And I would like to catch up with the changes I have on my github project. It will take 20-30 more patches like this. It's much easier to do this if I can diff the two source tree... And when I'm done with it, will make a patch on capitalization only, where we can fix my bad English, or reformulate comments when needed.

Mar 5 2017, 2:10 PM

Mar 3 2017

rizsotto.mailinglist created D30601: [scan-build-py] move argument parsing into separate module.
Mar 3 2017, 8:22 PM
rizsotto.mailinglist created D30600: [scan-build-py] fix some line separator issues.
Mar 3 2017, 8:16 PM
rizsotto.mailinglist updated the diff for D29260: [scan-build-py] create decorator for compiler wrapper methods.

change decorator to a simple higher order function. call is explicit now.

Mar 3 2017, 2:56 AM

Feb 24 2017

rizsotto.mailinglist added a comment to D29260: [scan-build-py] create decorator for compiler wrapper methods.

I got your concerns, but on this language decorator is the right tool to solve issues like this. Or we go with the no-decorator syntax, but doing exactly the same thing. What do you say?

If we can't figure out a way to abstract the functionality while keeping it clear then we shouldn't abstract it. It is more important to have the code be understandable than abstracted.

Feb 24 2017, 3:55 PM
rizsotto.mailinglist added a comment to D29260: [scan-build-py] create decorator for compiler wrapper methods.

Thanks Devin to clarify it in details. Before your comments were too high level, abstract to me. I prefer concrete code examples in reviews... So, thanks again, really appreciated.

Feb 24 2017, 4:07 AM

Feb 23 2017

rizsotto.mailinglist accepted D30252: Add clazy to external Clang examples page.
Feb 23 2017, 1:04 AM
rizsotto.mailinglist added a comment to D29260: [scan-build-py] create decorator for compiler wrapper methods.

Thanks Devin your explanation. I think decorators are kind of higher-order functions. Functions which are taking one-or-more functions as argument. It's a pretty powerful abstraction. And I don't think it's hard to understand them... But let's say, they are complex and scan-build-py shall not have any!

Feb 23 2017, 12:46 AM

Feb 19 2017

rizsotto.mailinglist added a reviewer for D29260: [scan-build-py] create decorator for compiler wrapper methods: akhiljaggarwal.
Feb 19 2017, 12:07 AM

Feb 14 2017

rizsotto.mailinglist updated the diff for D29260: [scan-build-py] create decorator for compiler wrapper methods.
Feb 14 2017, 4:05 AM
rizsotto.mailinglist added a reviewer for D29260: [scan-build-py] create decorator for compiler wrapper methods: jroelofs.
Feb 14 2017, 2:59 AM
rizsotto.mailinglist closed D29253: [scan-build-py] use subprocess wrapper to execute build.

Thanks Jonathan!

Feb 14 2017, 2:43 AM

Feb 6 2017

rizsotto.mailinglist added a comment to D29260: [scan-build-py] create decorator for compiler wrapper methods.

ping

Feb 6 2017, 1:54 PM
rizsotto.mailinglist added a comment to D29253: [scan-build-py] use subprocess wrapper to execute build.

ping

Feb 6 2017, 1:53 PM
rizsotto.mailinglist added a comment to D29255: [scan-build-py] move function report_directory from report module to analyze module.

ping

Feb 6 2017, 1:53 PM

Jan 30 2017

rizsotto.mailinglist added a comment to D29260: [scan-build-py] create decorator for compiler wrapper methods.

What is the benefit of the declarative decorator syntax here vs. a more imperative "with ... as" or a generator? It seems to me that using decorators here obscures the key components of the actual behavior of the function (calling the compiler, calling the analyzer) and makes it much harder to understand what the function is supposed to do.

Jan 30 2017, 4:26 PM

Jan 29 2017

rizsotto.mailinglist created D29260: [scan-build-py] create decorator for compiler wrapper methods.
Jan 29 2017, 12:39 AM

Jan 28 2017

rizsotto.mailinglist closed D29257: [scan-build-py] remove not used flag.

thanks Devin!

Jan 28 2017, 9:11 PM
rizsotto.mailinglist added a comment to D29245: [scan-build-py] use subprocess wrapper.

Is there an easy way to detect at run time whether the SELinux setup forbids library preload?

Jan 28 2017, 6:17 PM
rizsotto.mailinglist created D29257: [scan-build-py] remove not used flag.
Jan 28 2017, 5:20 PM
rizsotto.mailinglist created D29255: [scan-build-py] move function report_directory from report module to analyze module.
Jan 28 2017, 3:53 PM
rizsotto.mailinglist created D29253: [scan-build-py] use subprocess wrapper to execute build.
Jan 28 2017, 3:28 PM
rizsotto.mailinglist closed D29246: [scan-build-py] remove batch files.
Jan 28 2017, 3:09 PM
rizsotto.mailinglist closed D29245: [scan-build-py] use subprocess wrapper.

About the SELinux change. If the SELinux setup forbid the library preload, it won't work. But till now I have not met system which was configured like that. (Tested on Fedora 22-25.)

Jan 28 2017, 2:56 PM
rizsotto.mailinglist created D29246: [scan-build-py] remove batch files.
Jan 28 2017, 1:04 AM
rizsotto.mailinglist created D29245: [scan-build-py] use subprocess wrapper.
Jan 28 2017, 12:53 AM

Jan 21 2017

rizsotto.mailinglist abandoned D26390: [scan-build-py] port tests to lit (and major fixes).
Jan 21 2017, 6:18 PM

Nov 15 2016

rizsotto.mailinglist updated the diff for D26390: [scan-build-py] port tests to lit (and major fixes).

simplify intercept module

Nov 15 2016, 3:08 AM

Nov 13 2016

rizsotto.mailinglist updated the diff for D26390: [scan-build-py] port tests to lit (and major fixes).

fixed the issues i found and added tests too

Nov 13 2016, 1:01 AM

Nov 9 2016

rizsotto.mailinglist added a comment to D26390: [scan-build-py] port tests to lit (and major fixes).

unfortunately this code still has major issues, which i just caught recently with tests. fix comes soon. sorry.

Nov 9 2016, 1:44 PM

Nov 8 2016

rizsotto.mailinglist retitled D26390: [scan-build-py] port tests to lit (and major fixes) from to [scan-build-py] port tests to lit (and major fixes).
Nov 8 2016, 3:38 AM

Sep 23 2016

rizsotto.mailinglist closed D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module.

commited at r282317

Sep 23 2016, 5:31 PM

Sep 13 2016

rizsotto.mailinglist accepted D24470: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py.

thanks Devin, i like smaller code, have no problem with this change. :)

Sep 13 2016, 5:07 AM

Sep 2 2016

rizsotto.mailinglist added a comment to D24040: codechecker tool core.

Gyorgy and the ericsson team, thanks for doing this. very good job! good targeted functionality. i don't want to underestimate the complexity it requires, but to me this is a giant code. i do miss the explanation of the overall functional description what a module does and how it relates to other modules. i found a gap between the high level overview and the code comments.

Would that help If update architecture.md documentation (which gives a high level overview) to be more in sync with the source code, with additional comments and descriptions in the modules?

Sep 2 2016, 6:11 AM
rizsotto.mailinglist added a comment to D24163: [scan-build-py] Increase precision of timestamp in report directory name.

looks good to me. i like the test. :) but would keep the pep8 cleanness.

Sep 2 2016, 5:08 AM

Aug 31 2016

rizsotto.mailinglist added a comment to D24040: codechecker tool core.

Gyorgy and the ericsson team, thanks for doing this. very good job! good targeted functionality. i don't want to underestimate the complexity it requires, but to me this is a giant code. i do miss the explanation of the overall functional description what a module does and how it relates to other modules. i found a gap between the high level overview and the code comments.
generally speaking i found this code under documented and a bit verbose. the comments in the code is not really paint the picture that i need in order to fix a bug, or implement a feature. and it might only be my personal taste, but found that creating types (or classes this case) in a dynamically typed script language, it makes the code very verbose while it does not implement much.
was commented only on two random modules, but found the same patterns in many other ones.
found that this code is not pep8 conform. pylint found a lot of errors and warnings, and a couple of duplicate codes.
i hope we can fix these findings and that would make this code more solid and understood by others.

Aug 31 2016, 7:00 AM

Jun 12 2016

rizsotto.mailinglist added a comment to D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module.

hey Devin, thanks for looking to it.

Jun 12 2016, 1:20 AM

Apr 19 2016

rizsotto.mailinglist retitled D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module from to [analyzer][scan-build-py] subprocess output handling reviewed in clang module.
Apr 19 2016, 5:32 AM

Apr 16 2016

rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..

thanks Devin for the review. your comments are addressed in the new commit.

Apr 16 2016, 8:35 AM
rizsotto.mailinglist updated the diff for D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..
Apr 16 2016, 8:31 AM

Mar 20 2016

rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..

a gentle ping

Mar 20 2016, 11:19 PM

Mar 13 2016

rizsotto.mailinglist updated the diff for D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..
Mar 13 2016, 2:48 PM
rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..

dear Devin and Anna,

Mar 13 2016, 1:44 AM
rizsotto.mailinglist updated the diff for D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..
Mar 13 2016, 1:10 AM

Feb 23 2016

rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..

hey Anna, thanks for your reply!

Feb 23 2016, 7:15 PM
rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..

ping

Feb 23 2016, 5:00 PM

Feb 21 2016

rizsotto.mailinglist added a comment to D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..
  • -m* Perl implementation scan-build takes it in. i took it out, and got error reports that is actually needed for many cases.
  • -W* Perl implementation scan-build takes only the warning suppress flags -Wno-*, but says " We don't care about extra warnings, but we should suppress ones that we don't want to see." in the comment.
Feb 21 2016, 12:08 AM

Feb 20 2016

rizsotto.mailinglist updated subscribers of D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database..
Feb 20 2016, 7:31 PM
rizsotto.mailinglist retitled D17487: [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database. from to [analyzer][scan-build-py] Do not remove `-m*` flags from compilation database..
Feb 20 2016, 6:34 PM
rizsotto.mailinglist added a comment to D17091: [analyzer][scan-build-py] Non-existing directory for scan-build output..

the semicolon at the end of line 39 is an issue for PEP8. please remove it.

Feb 20 2016, 6:13 PM
rizsotto.mailinglist accepted D17091: [analyzer][scan-build-py] Non-existing directory for scan-build output..

thanks Anton, LGTM!

Feb 20 2016, 5:52 PM

Feb 1 2016

rizsotto.mailinglist added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

to me it appears a more reasonable solution. (it does not require a separate method and unit test around it.) maybe the same effort could be focus to write a functional test for it... that's only my thoughts. Devin or Anna, could you share your opinion?

Feb 1 2016, 7:40 PM

Jan 31 2016

rizsotto.mailinglist added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

sorry for it, but was thinking on the weekend and i have a lame question after the hard work: why not just append a -UNDEBUG to the end of the argument list? would not it make the same effect?

Jan 31 2016, 9:14 PM

Jan 29 2016

rizsotto.mailinglist accepted D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

thanks Yury!

Jan 29 2016, 3:36 PM

Jan 28 2016

rizsotto.mailinglist added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

thanks Yury for the update.

Jan 28 2016, 3:04 PM

Jan 21 2016

rizsotto.mailinglist added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

$ PATH=$(pwd)/bin:$PATH python -m unittest -v

I don't think so:

Jan 21 2016, 7:01 PM

Jan 19 2016

rizsotto.mailinglist added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

hey Yury,

Jan 19 2016, 1:48 AM

Jan 12 2016

rizsotto.mailinglist added a comment to D9600: Add scan-build python implementation.

Thank you guys for your review and help! The latest patch is commited. Let's do the next steps too. ;)

Jan 12 2016, 2:53 PM

Jan 5 2016

rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Jan 5 2016, 8:49 AM
rizsotto.mailinglist added a comment to D9600: Add scan-build python implementation.

sorry for the delay, hard to get free time these days. ;)

Jan 5 2016, 8:49 AM

Dec 14 2015

rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Dec 14 2015, 2:22 PM
rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 14 2015, 2:20 PM

Dec 11 2015

rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 11 2015, 3:48 PM
rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.

previous upload is broken, sorry for that

Dec 11 2015, 3:27 PM
rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Dec 11 2015, 3:03 PM
rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 11 2015, 3:00 PM

Dec 10 2015

rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 10 2015, 2:46 PM
rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Dec 10 2015, 1:09 PM
rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 10 2015, 1:06 PM
rizsotto.mailinglist added inline comments to D9600: Add scan-build python implementation.
Dec 10 2015, 3:55 AM
rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Dec 10 2015, 3:52 AM
rizsotto.mailinglist added a comment to D9600: Add scan-build python implementation.

thanks for the comments.

Dec 10 2015, 3:48 AM

Dec 9 2015

rizsotto.mailinglist updated the diff for D9600: Add scan-build python implementation.
Dec 9 2015, 8:09 AM
rizsotto.mailinglist added a comment to D9600: Add scan-build python implementation.

Also, what do you think about renaming intercept-build to "log-build" or some of the other alternatives I proposed above? I think it is important for the name of the executable to communicate its purpose.

Dec 9 2015, 8:07 AM