This is an archive of the discontinued LLVM Phabricator instance.

[lld][mips] Correct tests for mips64 implying PIC.
ClosedPublic

Authored by sdardis on Jan 26 2017, 12:30 PM.

Details

Summary

Currently LLVM can only generate PIC code for MIPS64 with the N64 as
it uses the idiom "isPositionIndependent() || IsABI_N64()" throughout the
MIPS backend. r293164 changed this, causing test failures for LLD.

This patch changes the tests minimally to preserve existing test coverage
and one case where the test was "right" in the wrong circumstance.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Jan 26 2017, 12:30 PM
atanasyan accepted this revision.Jan 26 2017, 1:29 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Jan 26 2017, 1:29 PM
This revision was automatically updated to reflect the committed changes.