This is an archive of the discontinued LLVM Phabricator instance.

Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().
ClosedPublic

Authored by mehdi_amini on Jan 23 2017, 6:39 PM.

Event Timeline

mehdi_amini created this revision.Jan 23 2017, 6:39 PM
steven_wu edited edge metadata.Jan 23 2017, 6:53 PM

I think you should add a new API for embedBitcodeMarkerEnabled() or revert the name the APIs to before https://reviews.llvm.org/rL287084.

I think you should add a new API for embedBitcodeMarkerEnabled() or revert the name the APIs to before https://reviews.llvm.org/rL287084.

I'm missing where rL287084 changed the name? It introduced a new API but didn't rename anything AFAICT, here is what it was before:

bool embedBitcodeEnabled() const { return BitcodeEmbed == EmbedBitcode; }
bool embedBitcodeEnabled() const { return BitcodeEmbed != EmbedNone; }
steven_wu accepted this revision.Jan 24 2017, 9:09 AM

Depending on how you look at the previous commit, you can think that as a new API or just rename the old API. I actually dont think there is too much issue names. Plz go ahead.

This revision is now accepted and ready to land.Jan 24 2017, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Sorry I just notice that when I look at driver today.

cfe/trunk/lib/Driver/Tools.cpp
6464 ↗(On Diff #85605)

Should this line actually be:

!(C.getDriver().embedBitcodeInObject() && !C.getDriver().isUsingLTO()) &&
mehdi_amini added inline comments.Jan 27 2017, 10:18 PM
cfe/trunk/lib/Driver/Tools.cpp
6464 ↗(On Diff #85605)

Thanks, r293370