This is an archive of the discontinued LLVM Phabricator instance.

Differential D28185

Rebase D26893 to master
Needs ReviewPublic

Authored by bero on Dec 30 2016, 1:03 PM.

Details

Reviewers
erik.pilkington
Summary

Patch from https://reviews.llvm.org/D26893 doesn't apply on master anymore -- attaching rebased patch

Diff Detail

Event Timeline

bero updated this revision to Diff 82743.Dec 30 2016, 1:03 PM
bero retitled this revision from to Rebase to master.
bero updated this object.
bero retitled this revision from Rebase to master to Rebase D26893 to master.Dec 30 2016, 1:06 PM
bero updated this object.
bero updated this object.
bero added a reviewer: erik.pilkington.
bero added a subscriber: erik.pilkington.

Revision Contents

PathSize
llvm-4.0.0.src/
tools/
clang/
lib/
Sema/
SemaTemplateDeduction.cpp
SemaTemplateDeduction.cpp.templateFix~
2 lines
test/
SemaTemplate/
deduction.cpp
deduction.cpp.templateFix~
11 lines

Diff 82743

llvm-4.0.0.src/tools/clang/lib/Sema/SemaTemplateDeduction.cpp

Context not available.
// Check whether we have enough arguments. // Check whether we have enough arguments.
if (!hasTemplateArgumentForDeduction(Args, ArgIdx)) if (!hasTemplateArgumentForDeduction(Args, ArgIdx))
return NumberOfArgumentsMustMatch ? Sema::TDK_TooFewArguments return NumberOfArgumentsMustMatch ? Sema::TDK_MiscellaneousDeductionFailure
: Sema::TDK_Success; : Sema::TDK_Success;
if (Args[ArgIdx].isPackExpansion()) { if (Args[ArgIdx].isPackExpansion()) {
Context not available.

llvm-4.0.0.src/tools/clang/test/SemaTemplate/deduction.cpp

Context not available.
template<typename T> int B<T, typename Fail<T>::error> {}; // expected-note {{instantiation of}} template<typename T> int B<T, typename Fail<T>::error> {}; // expected-note {{instantiation of}}
int bi = B<char, char>; // expected-note {{during template argument deduction for variable template partial specialization 'B<T, typename Fail<T>::error>' [with T = char]}} int bi = B<char, char>; // expected-note {{during template argument deduction for variable template partial specialization 'B<T, typename Fail<T>::error>' [with T = char]}}
} }
namespace PR31043 {
template <class... Ts>
struct tuple {};
template <class T>
int foo(tuple<T>); // expected-note{{candidate template ignored: failed template argument deduction}}
int z = foo(tuple<>{}); // expected-error{{no matching function call to 'foo'}}
}
Context not available.