This is an archive of the discontinued LLVM Phabricator instance.

Make two vtable tests tolerate C++11
ClosedPublic

Authored by probinson on Dec 20 2016, 11:38 AM.

Details

Summary

In C++11, we don't emit vtables as eagerly as we do for C++03, so fiddle the tests to emit them when the test expects them.

In the C++11 test cleanup project, we're commonly making the tests run in both dialects and sometimes with no dialect specified (as Clang's default will presumably advance to C++14/17 at some point). I didn't do that for vtable-layout.cpp because it runs FileCheck 46 times, and replicating that really seemed like too much.
If it also seems like too much for vtable-linkage.cpp, the easy thing is to force it to C++03.

Diff Detail

Repository
rL LLVM

Event Timeline

probinson updated this revision to Diff 82126.Dec 20 2016, 11:38 AM
probinson retitled this revision from to Make two vtable tests tolerate C++11.
probinson updated this object.
probinson added a reviewer: rjmccall.
probinson added a subscriber: cfe-commits.
rjmccall accepted this revision.Dec 20 2016, 2:10 PM
rjmccall edited edge metadata.

No, seems fine to me.

This revision is now accepted and ready to land.Dec 20 2016, 2:10 PM
This revision was automatically updated to reflect the committed changes.