This is an archive of the discontinued LLVM Phabricator instance.

Update mailing list post URL
ClosedPublic

Authored by emaste on Dec 19 2016, 6:39 PM.

Diff Detail

Event Timeline

emaste updated this revision to Diff 82054.Dec 19 2016, 6:39 PM
emaste retitled this revision from to Update mailing list post URL.
emaste updated this object.
emaste added reviewers: andrew.w.kaylor, rafael.
emaste added a subscriber: Restricted Project.
andrew.w.kaylor accepted this revision.Dec 21 2016, 12:37 PM
andrew.w.kaylor edited edge metadata.

It looks to me like you are probably correct about the intended mailing list post, but it's still not particularly helpful. It would be nice to have a reference to a primary source, but this is the best I could find:

https://opensource.apple.com/source/libunwind/libunwind-35.3/src/UnwindLevel1-gcc-ext.c

In any event, your change seems like a step forward so lgtm.

This revision is now accepted and ready to land.Dec 21 2016, 12:37 PM

It looks to me like you are probably correct about the intended mailing list post, but it's still not particularly helpful. It would be nice to have a reference to a primary source, but this is the best I could find:

https://opensource.apple.com/source/libunwind/libunwind-35.3/src/UnwindLevel1-gcc-ext.c

Yes, I couldn't find a primary source. It seems the expected behaviour is not documented by GCC, but GCC's API is the de-facto correct one.

My guess is that the Apple API is just a bug. I've modified libunwind in FreeBSD to implement GCC's libgcc API: https://svnweb.freebsd.org/changeset/base/310365

This revision was automatically updated to reflect the committed changes.

this is the best I could find:

https://opensource.apple.com/source/libunwind/libunwind-35.3/src/UnwindLevel1-gcc-ext.c

Oh, good point on this file: I also added a reference to its canonical location in the llvm tree.