This is an archive of the discontinued LLVM Phabricator instance.

Make CodeGenCXX/stack-reuse-miscompile.cpp tolerate C++11
ClosedPublic

Authored by probinson on Dec 19 2016, 2:43 PM.

Details

Summary

In this test, the allocas for the temps come out in a different order depending on whether the dialect is C++03 or C++11. To avoid depending on the default dialect, I forced it to C++03.

I am concerned, though, because the commentary says there should be no lifetime intrinsics. While that was true in Clang 3.8, it is no longer true in Clang 3.9, regardless of dialect. However, the test does not actually verify that there are no lifetime intrinsics.

Is it still true that there should be no lifetime intrinsics? If so, then there is a bug that the test has failed to detect. If not, then the comment should be updated.

Diff Detail

Repository
rL LLVM

Event Timeline

probinson updated this revision to Diff 82020.Dec 19 2016, 2:43 PM
probinson retitled this revision from to Make CodeGenCXX/stack-reuse-miscompile.cpp tolerate C++11.
probinson updated this object.
probinson added a reviewer: lenykholodov.
probinson added a subscriber: cfe-commits.
This revision was automatically updated to reflect the committed changes.