Page MenuHomePhabricator

[modules] Add optional out-param to ASTReader::ReadAST for imported submodules.
ClosedPublic

Authored by graydon on Dec 8 2016, 10:20 AM.

Details

Summary

The Swift frontend is acquiring the ability to load non-module PCH files containing
bridging definitions from C/ObjC. As part of this work, it needs to know which submodules
were imported by a PCH in order to wrap them in local Swift modules. This information
is collected by ASTReader::ReadAST in a local vector, but is currently kept private.

The change here is just to make the type of the vector elements public, and provide
an optional out-parameter to the ReadAST method to provide the vector's contents to
a caller after a successful read.

Diff Detail

Repository
rL LLVM

Event Timeline

graydon updated this revision to Diff 80782.Dec 8 2016, 10:20 AM
graydon retitled this revision from to [modules] Add optional out-param to ASTReader::ReadAST for imported submodules..
graydon updated this object.
graydon added reviewers: doug.gregor, manmanren, rsmith.
graydon added a subscriber: cfe-commits.
doug.gregor accepted this revision.Dec 8 2016, 10:21 AM
doug.gregor edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Dec 8 2016, 10:21 AM
This revision was automatically updated to reflect the committed changes.