Page MenuHomePhabricator

Use Timeout<> in Process::RunThreadPlan
ClosedPublic

Authored by labath on Nov 30 2016, 7:39 AM.

Details

Summary

Since the function is way too big already, I tried at least to factor out the
timeout computation stuff into a separate function. I've tried to make the new
code semantically equivalent, and it also makes sense when I look at it as a done
deal, but I could use another pair of eyes for this.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 79737.Nov 30 2016, 7:39 AM
labath retitled this revision from to Use Timeout<> in Process::RunThreadPlan.
labath updated this object.
labath added a reviewer: jingham.
labath added a subscriber: lldb-commits.
jingham accepted this revision.Nov 30 2016, 11:21 AM
jingham edited edge metadata.

That looks correct to me as well. Thanks for taking the time to clean this up.

source/Target/Process.cpp
4926–4928 ↗(On Diff #79737)

without -> with

The error was in the original.

This revision is now accepted and ready to land.Nov 30 2016, 11:21 AM
This revision was automatically updated to reflect the committed changes.