Page MenuHomePhabricator

Only computeRelativePath() on new members
ClosedPublic

Authored by marksantaniello on Nov 29 2016, 10:33 AM.

Details

Summary

When using thin archives, and processing the same archive multiple times, we were mangling existing entries. The root cause is that we were calling computeRelativePath() more than once. Here, we only call it when adding new members to an archive.

Note that D27218 changes the way thin archives are printed, and will break the new unit test included here. Depending on which one lands first, the other will need to be slightly modified.

Diff Detail

Repository
rL LLVM

Event Timeline

marksantaniello retitled this revision from to Only computeRelativePath() on new members.
marksantaniello updated this object.
marksantaniello added reviewers: rafael, davide.
marksantaniello set the repository for this revision to rL LLVM.
marksantaniello added a subscriber: llvm-commits.
davide accepted this revision.Nov 29 2016, 6:13 PM
davide edited edge metadata.

LGTM. Do you need somebody to commit this on your behalf?

This revision is now accepted and ready to land.Nov 29 2016, 6:13 PM
marksantaniello edited edge metadata.
marksantaniello removed rL LLVM as the repository for this revision.

Remove trailing whitespace

Previous diff was a mistake. Got the revisions mixed up. Here I add the final newline to the new test.

This revision was automatically updated to reflect the committed changes.

Thanks @davide, looks like I'm all set since @david2050 already did it.