This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Always use -std=gnu89 for 253.perlbmk
ClosedPublic

Authored by jdoerfert on Nov 15 2016, 9:00 AM.

Download Raw Diff

Details

Reviewers

sebpop
kristof.beyls
MatzeB

Commits

rOLDT286985: [test-suite] Always use -std=gnu89 for 253.perlbmk
rL286985: [test-suite] Always use -std=gnu89 for 253.perlbmk

Summary

If this flag is not present the different "external inline" behaviour
will cause link time problems. In r261470 this option was already added
to the CMakeLists.txt but not to the Makefile.

Diff Detail

Repository: rL LLVM

Event Timeline

jdoerfert updated this revision to Diff 78016.Nov 15 2016, 9:00 AM

jdoerfert retitled this revision from to [test-suite] Always use -std=gnu89 for 253.perlbmk.

jdoerfert updated this object.

jdoerfert added reviewers: sebpop, MatzeB, kristof.beyls.

jdoerfert set the repository for this revision to rL LLVM.

LGTM

This revision is now accepted and ready to land.Nov 15 2016, 9:08 AM

Closed by commit rL286985: [test-suite] Always use -std=gnu89 for 253.perlbmk (authored by jdoerfert). · Explain WhyNov 15 2016, 9:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test-suite/

trunk/

External/

SPEC/

CINT2000/

253.perlbmk/

Makefile

1 line

Diff 78018

test-suite/trunk/External/SPEC/CINT2000/253.perlbmk/Makefile

	LEVEL = ../../../..			LEVEL = ../../../..
	REQUIRES_EH_SUPPORT = 1			REQUIRES_EH_SUPPORT = 1
	include $(LEVEL)/Makefile.config			include $(LEVEL)/Makefile.config

	SPEC_ROOT := $(SPEC2000_ROOT)			SPEC_ROOT := $(SPEC2000_ROOT)

	include $(PROJ_SRC_ROOT)/External/SPEC/Makefile.spec.config			include $(PROJ_SRC_ROOT)/External/SPEC/Makefile.spec.config

	CPPFLAGS += -DSPEC_CPU2000_LINUX_I386 -DSPEC_CPU2000_NEED_BOOL			CPPFLAGS += -DSPEC_CPU2000_LINUX_I386 -DSPEC_CPU2000_NEED_BOOL
				CFLAGS += -std=gnu89

	# Not sure why this is needed.			# Not sure why this is needed.
	ifndef RUN_TYPE			ifndef RUN_TYPE
	ifdef SMALL_PROBLEM_SIZE			ifdef SMALL_PROBLEM_SIZE
	RUN_TYPE=test			RUN_TYPE=test
	else			else
	ifdef LARGE_PROBLEM_SIZE			ifdef LARGE_PROBLEM_SIZE
	RUN_TYPE=ref			RUN_TYPE=ref
	▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines