This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Sort the SPEC file outputs to force a deterministic result
ClosedPublic

Authored by jdoerfert on Nov 15 2016, 8:59 AM.

Details

Summary

The wildcard used to reference all files generated by a SPEC benchmark
does not guarantee an ordered result. Probably depending on the default
shell e.g., with zsh 5.2, some SPEC benchmarks* did mistakenly fail.

Diff Detail

Repository
rL LLVM

Event Timeline

jdoerfert updated this revision to Diff 78015.Nov 15 2016, 8:59 AM
jdoerfert retitled this revision from to [test-suite] Sort the SPEC file outputs to force a deterministic result.
jdoerfert updated this object.
jdoerfert added reviewers: sebpop, kristof.beyls, MatzeB.
jdoerfert set the repository for this revision to rL LLVM.
jdoerfert added a subscriber: jdoerfert.
MatzeB accepted this revision.Nov 15 2016, 9:11 AM
MatzeB edited edge metadata.

LGTM

BTW: I really recommend using the cmake/lit variant to run SPEC, the Makefiles only run something resembling the SPEC train inputs and are not necessary representativ of the actual performance measured in SPEC.

This revision is now accepted and ready to land.Nov 15 2016, 9:11 AM

Thanks for the tip!

I'm (currently almost) only interested in the compilation of SPEC and I have a setup that works with the old "nt" driver. I will switch at some point soon though!

This revision was automatically updated to reflect the committed changes.