This is an archive of the discontinued LLVM Phabricator instance.

Fix TestMiniDumpNew.py test for Python 2/3 issue
ClosedPublic

Authored by amccarth on Nov 14 2016, 3:42 PM.

Details

Summary

On Windows, where we use Python 3 for testing, we have to be more explicit about converting between binary and string representations. I believe this should still work for Python 2, but I don't have a convenient way to try it out.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 77900.Nov 14 2016, 3:42 PM
amccarth retitled this revision from to Fix TestMiniDumpNew.py test for Python 2/3 issue.
amccarth updated this object.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
zturner accepted this revision.Nov 14 2016, 3:51 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Nov 14 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.