Fix uninitialized members.

[sammccall]

Summary

Fix uninitialized members.

[sammccall]

• Use in-class member initializers (for whole classes)
• remove init-list entries that are redundant with in-class initializer

[jingham]

Looks fine to me.

lldb/trunk/include/lldb/Host/FileSpec.h

public:
   static EnumerateDirectoryResult
   ForEachItemInDirectory(llvm::StringRef dir_path,
                          DirectoryCallback const &callback);
 
 protected:
   //------------------------------------------------------------------
   // Member variables
   //------------------------------------------------------------------
-  ConstString m_directory;    ///< The uniqued directory path
-  ConstString m_filename;     ///< The uniqued filename path
-  mutable bool m_is_resolved; ///< True if this path has been resolved.
+  ConstString m_directory;            ///< The uniqued directory path
+  ConstString m_filename;             ///< The uniqued filename path
+  mutable bool m_is_resolved = false; ///< True if this path has been resolved.
   PathSyntax
       m_syntax; ///< The syntax that this path uses (e.g. Windows / Posix)
 };
 
 //----------------------------------------------------------------------
 /// Dump a FileSpec object to a stream
 //----------------------------------------------------------------------
 Stream &operator<<(Stream &s, const FileSpec &f);
 
 } // namespace lldb_private
 
 #endif // liblldb_FileSpec_h_

lldb/trunk/source/Host/common/FileSpec.cpp

#endif // #ifdef LLDB_CONFIG_TILDE_RESOLVES_TO_USER
 
   llvm::sys::fs::make_absolute(path);
   if (!llvm::sys::fs::exists(path)) {
     path.clear();
     path.append(original_path.begin(), original_path.end());
   }
 }
 
-FileSpec::FileSpec()
-    : m_directory(), m_filename(), m_syntax(FileSystem::GetNativePathSyntax()) {
-}
+FileSpec::FileSpec() : m_syntax(FileSystem::GetNativePathSyntax()) {}
 
 //------------------------------------------------------------------
 // Default constructor that can take an optional full path to a
 // file on disk.
 //------------------------------------------------------------------
 FileSpec::FileSpec(llvm::StringRef path, bool resolve_path, PathSyntax syntax)
-    : m_directory(), m_filename(), m_is_resolved(false), m_syntax(syntax) {
+    : m_syntax(syntax) {
   SetFile(path, resolve_path, syntax);
 }
 
 FileSpec::FileSpec(llvm::StringRef path, bool resolve_path, ArchSpec arch)
     : FileSpec{path, resolve_path, arch.GetTriple().isOSWindows()
                                        ? ePathSyntaxWindows
                                        : ePathSyntaxPosix} {}
 

lldb/trunk/source/Target/Process.cpp

void Process::STDIOReadThreadBytesReceived(void *baton, const void *src,
   process->AppendSTDOUT(static_cast<const char *>(src), src_len);
 }
 
 class IOHandlerProcessSTDIO : public IOHandler {
 public:
   IOHandlerProcessSTDIO(Process *process, int write_fd)
       : IOHandler(process->GetTarget().GetDebugger(),
                   IOHandler::Type::ProcessIO),
-        m_process(process), m_read_file(), m_write_file(write_fd, false),
-        m_pipe() {
+        m_process(process), m_write_file(write_fd, false) {
     m_pipe.CreateNew(false);
     m_read_file.SetDescriptor(GetInputFD(), false);
   }
 
   ~IOHandlerProcessSTDIO() override = default;
 
   // Each IOHandler gets to run until it is done. It should read data
   // from the "in" and place output into "out" and "err and return
#endif
   void GotEOF() override {}
 
 protected:
   Process *m_process;
   File m_read_file;  // Read from this file (usually actual STDIN for LLDB
   File m_write_file; // Write to this file (usually the master pty for getting
                      // io to debuggee)
   Pipe m_pipe;
-  std::atomic<bool> m_is_running;
+  std::atomic<bool> m_is_running{false};
 };
 
 void Process::SetSTDIOFileDescriptor(int fd) {
   // First set up the Read Thread for reading/handling process I/O
 
   std::unique_ptr<ConnectionFileDescriptor> conn_ap(
       new ConnectionFileDescriptor(fd, true));