Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

[tfiala]

Summary

BuildAndIntegration is the configuration used to build Apple-built LLDB. This configuration currently requires NDEBUG to be specified. This change adds a new Xcode variable, LLDB_NDEBUG_CFLAGS, which specifies "-DNDEBUG" when using the BuildAndIntegration configuration, and specifies nothing for all other configurations. All binaries have been modified to include $(LLDB_NDEBUG_CFLAGS) in the full set of other cflags and other cxxflags.

[tfiala]

Adding Jim, as I just want one of him or Greg to review.

[clayborg]

If we do this the asserts we have will no longer fire. We tend not to use asserts too much, but it would be a good idea to take a look at any asserts in our code to make sure we won't die horribly in other ways that will cause us not to know what crashed us.

[clayborg]

We will need to take a look at the existing assert calls within LLDB and within LLVM to make sure we won't cause things to crash at a later time with no context as to what happened. Any code that asserts should actually be able to continue without problems, but I know that isn't the case for us and certainly isn't for llvm and clang.

[tfiala]

This one needs more analysis.

I'm bowing out of it. Greg, you might want to pick this one up?

project.pbxproj

1DEB91F008733DB70010E9CD /* Debug */ = {
         LLDB_COVERAGE_CFLAGS = "$(LLDB_COVERAGE_CFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_CFLAGS_1 = "-fprofile-instr-generate -fcoverage-mapping";
         LLDB_COVERAGE_LDFLAGS = "$(LLDB_COVERAGE_LDFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_LDFLAGS_1 = "-fprofile-instr-generate";
         LLDB_DISABLE_PYTHON = 0;
         "LLDB_DISABLE_PYTHON[sdk=iphoneos*]" = 1;
         LLDB_ENABLE_COVERAGE = 0;
         LLDB_FRAMEWORK_INSTALL_DIR = /Applications/Xcode.app/Contents/SharedFrameworks;
+        LLDB_NDEBUG_CFLAGS = "";
         LLDB_TOOLS_INSTALL_DIR = /usr/bin;
         LLDB_ZLIB_CFLAGS = "-DHAVE_LIBZ=1";
         LLDB_ZLIB_LDFLAGS = "-lz";
         LLVM_BUILD_DIR = "$(SRCROOT)/llvm-build/$(LLVM_CONFIGURATION)";
         LLVM_BUILD_DIRTREE = "$(SRCROOT)/llvm-build";
         LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
         LLVM_CONFIGURATION = "Release+Asserts";
         LLVM_SOURCE_DIR = "$(SRCROOT)/llvm";
         MACOSX_DEPLOYMENT_TARGET = 10.9;
         ONLY_ACTIVE_ARCH = YES;
         OTHER_CFLAGS = (
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_COVERAGE_CFLAGS)",
           "-Wimplicit-fallthrough",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(LLDB_COMPRESSION_LDFLAGS)",
           "$(LLDB_ZLIB_LDFLAGS)",
           "$(LLDB_COVERAGE_LDFLAGS)",
         );
         PYTHON_FRAMEWORK_PATH = /System/Library/Frameworks/Python.framework;
         PYTHON_VERSION_MAJOR = 2;
1DEB91F108733DB70010E9CD /* Release */ = {
         LLDB_COVERAGE_CFLAGS = "$(LLDB_COVERAGE_CFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_CFLAGS_1 = "-fprofile-instr-generate -fcoverage-mapping";
         LLDB_COVERAGE_LDFLAGS = "$(LLDB_COVERAGE_LDFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_LDFLAGS_1 = "-fprofile-instr-generate";
         LLDB_DISABLE_PYTHON = 0;
         "LLDB_DISABLE_PYTHON[sdk=iphoneos*]" = 1;
         LLDB_ENABLE_COVERAGE = 0;
         LLDB_FRAMEWORK_INSTALL_DIR = /Applications/Xcode.app/Contents/SharedFrameworks;
+        LLDB_NDEBUG_CFLAGS = "";
         LLDB_TOOLS_INSTALL_DIR = /usr/bin;
         LLDB_ZLIB_CFLAGS = "-DHAVE_LIBZ=1";
         LLDB_ZLIB_LDFLAGS = "-lz";
         LLVM_BUILD_DIR = "$(SRCROOT)/llvm-build/$(LLVM_CONFIGURATION)";
         LLVM_BUILD_DIRTREE = "$(SRCROOT)/llvm-build";
         LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
         LLVM_CONFIGURATION = "Release+Asserts";
         LLVM_SOURCE_DIR = "$(SRCROOT)/llvm";
         MACOSX_DEPLOYMENT_TARGET = 10.9;
         ONLY_ACTIVE_ARCH = YES;
         OTHER_CFLAGS = (
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_COVERAGE_CFLAGS)",
           "-Wimplicit-fallthrough",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(LLDB_COMPRESSION_LDFLAGS)",
           "$(LLDB_ZLIB_LDFLAGS)",
           "$(LLDB_COVERAGE_LDFLAGS)",
         );
         PYTHON_FRAMEWORK_PATH = /System/Library/Frameworks/Python.framework;
         PYTHON_VERSION_MAJOR = 2;
23CB15521D66DA9300EDDDE1 /* Debug */ = {
         LLDB_GTESTS_LDFLAGS = "$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L $(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
         OTHER_CFLAGS = (
           "-fno-rtti",
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_GTESTS_CFLAGS)",
           "-DGTEST_HAS_RTTI=0",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(inherited)",
           "-filelist",
           "$(LLVM_BUILD_DIR)/archives.txt",
           "-framework",
           Foundation,
           "-framework",
23CB15531D66DA9300EDDDE1 /* DebugClang */ = {
         LLDB_GTESTS_LDFLAGS = "$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L $(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
         OTHER_CFLAGS = (
           "-fno-rtti",
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_GTESTS_CFLAGS)",
           "-DGTEST_HAS_RTTI=0",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(inherited)",
           "-filelist",
           "$(LLVM_BUILD_DIR)/archives.txt",
           "-framework",
           Foundation,
           "-framework",
23CB15541D66DA9300EDDDE1 /* Release */ = {
         LLDB_GTESTS_LDFLAGS = "$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L $(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
         OTHER_CFLAGS = (
           "-fno-rtti",
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_GTESTS_CFLAGS)",
           "-DGTEST_HAS_RTTI=0",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(inherited)",
           "-filelist",
           "$(LLVM_BUILD_DIR)/archives.txt",
           "-framework",
           Foundation,
           "-framework",
23CB15551D66DA9300EDDDE1 /* BuildAndIntegration */ = {
         LLDB_GTESTS_LDFLAGS = "$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L $(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
         OTHER_CFLAGS = (
           "-fno-rtti",
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_GTESTS_CFLAGS)",
           "-DGTEST_HAS_RTTI=0",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(inherited)",
           "-filelist",
           "$(LLVM_BUILD_DIR)/archives.txt",
           "-framework",
           Foundation,
           "-framework",
268A89B211963ECA00D953EB /* BuildAndIntegration */ = {
         LLDB_COVERAGE_CFLAGS_1 = "-fprofile-instr-generate -fcoverage-mapping";
         LLDB_COVERAGE_LDFLAGS = "$(LLDB_COVERAGE_LDFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_LDFLAGS_1 = "-fprofile-instr-generate";
         LLDB_DISABLE_PYTHON = 0;
         "LLDB_DISABLE_PYTHON[sdk=iphoneos*]" = 1;
         LLDB_ENABLE_COVERAGE = 0;
         LLDB_FRAMEWORK_INSTALL_DIR = /Applications/Xcode.app/Contents/SharedFrameworks;
         "LLDB_FRAMEWORK_INSTALL_DIR[sdk=iphoneos*]" = /System/Library/PrivateFrameworks;
+        LLDB_NDEBUG_CFLAGS = "-DNDEBUG";
         LLDB_TOOLS_INSTALL_DIR = /Applications/Xcode.app/Contents/Developer/usr/bin;
         "LLDB_TOOLS_INSTALL_DIR[sdk=iphoneos*]" = /usr/local/bin;
         LLDB_ZLIB_CFLAGS = "-DHAVE_LIBZ=1";
         LLDB_ZLIB_LDFLAGS = "-lz";
         LLVM_BUILD_DIR = "$(OBJROOT)/llvm";
         LLVM_BUILD_DIRTREE = "$(OBJROOT)/llvm-build";
         LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
         LLVM_CONFIGURATION = Release;
         LLVM_SOURCE_DIR = "$(SRCROOT)/llvm";
         MACOSX_DEPLOYMENT_TARGET = "";
         OTHER_CFLAGS = (
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_COVERAGE_CFLAGS)",
           "-Wimplicit-fallthrough",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(LLDB_COMPRESSION_LDFLAGS)",
           "$(LLDB_ZLIB_LDFLAGS)",
           "$(LLDB_COVERAGE_LDFLAGS)",
         );
         PYTHON_FRAMEWORK_PATH = /System/Library/Frameworks/Python.framework;
         PYTHON_VERSION_MAJOR = 2;
49BB8F341611172B00BDD462 /* DebugClang */ = {
         LLDB_COVERAGE_CFLAGS = "$(LLDB_COVERAGE_CFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_CFLAGS_1 = "-fprofile-instr-generate -fcoverage-mapping";
         LLDB_COVERAGE_LDFLAGS = "$(LLDB_COVERAGE_LDFLAGS_$(LLDB_ENABLE_COVERAGE))";
         LLDB_COVERAGE_LDFLAGS_1 = "-fprofile-instr-generate";
         LLDB_DISABLE_PYTHON = 0;
         "LLDB_DISABLE_PYTHON[sdk=iphoneos*]" = 1;
         LLDB_ENABLE_COVERAGE = 0;
         LLDB_FRAMEWORK_INSTALL_DIR = /Applications/Xcode.app/Contents/SharedFrameworks;
+        LLDB_NDEBUG_CFLAGS = "";
         LLDB_TOOLS_INSTALL_DIR = /usr/bin;
         LLDB_ZLIB_CFLAGS = "-DHAVE_LIBZ=1";
         LLDB_ZLIB_LDFLAGS = "-lz";
         LLVM_BUILD_DIR = "$(SRCROOT)/llvm-build/$(LLVM_CONFIGURATION)";
         LLVM_BUILD_DIRTREE = "$(SRCROOT)/llvm-build";
         LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
         LLVM_CONFIGURATION = "Debug+Asserts";
         LLVM_SOURCE_DIR = "$(SRCROOT)/llvm";
         MACOSX_DEPLOYMENT_TARGET = 10.9;
         ONLY_ACTIVE_ARCH = YES;
         OTHER_CFLAGS = (
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_COVERAGE_CFLAGS)",
           "-Wimplicit-fallthrough",
+          "$(LLDB_NDEBUG_CFLAGS)",
         );
         OTHER_LDFLAGS = (
           "$(LLDB_COMPRESSION_LDFLAGS)",
           "$(LLDB_ZLIB_LDFLAGS)",
           "$(LLDB_COVERAGE_LDFLAGS)",
         );
         PYTHON_FRAMEWORK_PATH = /System/Library/Frameworks/Python.framework;
         PYTHON_VERSION_MAJOR = 2;