This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Fix NOLINT test
ClosedPublic

Authored by nkakuev on Nov 9 2016, 10:58 AM.

Download Raw Diff

Details

Reviewers

Commits

rG2e888fe16583: [clang-tidy] Fix NOLINT test
rCTE292926: [clang-tidy] Fix NOLINT test
rL292926: [clang-tidy] Fix NOLINT test

Summary

Test cases I've added in review D26218 were too brittle and weren't working properly.
This patch fixes this.

Diff Detail

Repository: rL LLVM

Event Timeline

nkakuev updated this revision to Diff 77378.Nov 9 2016, 10:58 AM

nkakuev retitled this revision from to [clang-tidy] Fix NOLINT test.

nkakuev updated this object.

nkakuev added a reviewer: alexfh.

nkakuev mentioned this in D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT.

nkakuev added a subscriber: cfe-commits.

Thanks! LG

This revision is now accepted and ready to land.Nov 9 2016, 3:56 PM

@alexfh, you're welcome!
Can you please commit this patch?

Ping.

Closed by commit rL292926: [clang-tidy] Fix NOLINT test (authored by alexfh). · Explain WhyJan 24 2017, 4:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clang-tools-extra/

trunk/

test/

clang-tidy/

nolint.cpp

15 lines

Diff 85571

clang-tools-extra/trunk/test/clang-tidy/nolint.cpp

	// RUN: %check_clang_tidy %s google-explicit-constructor,clang-diagnostic-unused-variable,clang-analyzer-core.UndefinedBinaryOperatorResult %t -- -extra-arg=-Wunused-variable -- -I%S/Inputs/nolint			// RUN: %check_clang_tidy %s google-explicit-constructor,clang-diagnostic-unused-variable,clang-analyzer-core.UndefinedBinaryOperatorResult %t -- -extra-arg=-Wunused-variable -- -I%S/Inputs/nolint

				#include "trigger_warning.h"
				void I(int& Out) {
				int In;
				A1(In, Out);
				}
				// CHECK-MESSAGES-NOT: trigger_warning.h:{{.*}} warning
				// CHECK-MESSAGES-NOT: :[[@LINE-4]]:{{.*}} note

	class A { A(int i); };			class A { A(int i); };
	// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: single-argument constructors must be marked explicit			// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: single-argument constructors must be marked explicit

	class B { B(int i); }; // NOLINT			class B { B(int i); }; // NOLINT

	class C { C(int i); }; // NOLINT(we-dont-care-about-categories-yet)			class C { C(int i); }; // NOLINT(we-dont-care-about-categories-yet)

	Show All 12 Lines
	MACRO_NOARG // NOLINT			MACRO_NOARG // NOLINT

	#define MACRO_NOLINT class G { G(int i); }; // NOLINT			#define MACRO_NOLINT class G { G(int i); }; // NOLINT
	MACRO_NOLINT			MACRO_NOLINT

	#define DOUBLE_MACRO MACRO(H) // NOLINT			#define DOUBLE_MACRO MACRO(H) // NOLINT
	DOUBLE_MACRO			DOUBLE_MACRO

	#include "trigger_warning.h"
	void I(int& Out) {
	int In;
	A1(In, Out);
	}
	// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a garbage value
	// CHECK-NOT: :[[@LINE-4]]:{{.*}} note

	// CHECK-MESSAGES: Suppressed 8 warnings (8 NOLINT)			// CHECK-MESSAGES: Suppressed 8 warnings (8 NOLINT)