This is an archive of the discontinued LLVM Phabricator instance.

Remove TimeValue usage from Core/Module
ClosedPublic

Authored by labath on Nov 3 2016, 3:47 AM.

Details

Summary

The only interesting part here is that TimePoint and TimeValue have different
natural string representations, which affects "target modules list" output. It
is now "2016-07-09 04:02:21.000000000", whereas previously in was
"Sat Jul 9 04:02:21 2016". I wanted to check if we're OK with that.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 76832.Nov 3 2016, 3:47 AM
labath retitled this revision from to Remove TimeValue usage from Core/Module.
labath updated this object.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
clayborg edited edge metadata.Nov 7 2016, 8:59 AM

It would be great if we can match the old format somehow. It is definitely clearer. If we can't, don't worry about it too much as it isn't shown by default. Hopefully no one is text scraping.

labath updated this revision to Diff 77209.Nov 8 2016, 9:59 AM
labath edited edge metadata.

It turns out this was the only usage of TimeValue::Dump. I've changed that into a
standalone function so it can be called without a TimeValue. Once Zachary lands
the formatting change in llvm I'd like add a more generic time formatting
function there, and remove this custom one.

clayborg accepted this revision.Nov 8 2016, 10:02 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 10:02 AM
This revision was automatically updated to reflect the committed changes.