This is an archive of the discontinued LLVM Phabricator instance.

[Kaleidoscope] Fix incorrect build command in Chapter 2.
AcceptedPublic

Authored by ibadawi on Nov 1 2016, 11:42 AM.

Details

Reviewers
lhames
Summary

rL281945 made the Chapter 2 code use llvm::make_unique. The code was previously standalone, but it now needs to point to the llvm headers in order to build.

Diff Detail

Event Timeline

ibadawi updated this revision to Diff 76610.Nov 1 2016, 11:42 AM
ibadawi retitled this revision from to [Kaleidoscope] Fix incorrect build command in Chapter 2..
ibadawi updated this object.
ibadawi added a reviewer: lhames.
ibadawi added a subscriber: llvm-commits.
lhames accepted this revision.Jun 29 2017, 4:30 PM

Oops. *Very* belatedly: This looks good to me. Ismail - do you have commit access? If not, I can commit on your behalf.

This revision is now accepted and ready to land.Jun 29 2017, 4:30 PM

No worries! No, I don't have commit access -- go ahead and commit it. Thanks.