Page MenuHomePhabricator

[docs] Update some obsolete information in BitCodeFormat docs.
ClosedPublic

Authored by ibadawi on Oct 14 2016, 8:40 AM.

Details

Summary
  • Describe new (3.3) parameter attribute group encoding, leaving old encoding there with a note about legacy
  • Bring TYPE_BLOCK docs up to date
  • Remove docs about obsolete (pre 3.0) TYPE_SYMTAB_BLOCK, TST_CODE_ENTRY
  • Fix a couple of incorrect comments and remove one unused enum definition along the way

This addresses https://llvm.org/bugs/show_bug.cgi?id=28941.

Diff Detail

Repository
rL LLVM

Event Timeline

ibadawi updated this revision to Diff 74692.Oct 14 2016, 8:40 AM
ibadawi retitled this revision from to [docs] Update some obsolete information in BitCodeFormat docs..
ibadawi updated this object.
ibadawi added a subscriber: llvm-commits.
mehdi_amini accepted this revision.Oct 14 2016, 9:00 AM
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a subscriber: mehdi_amini.

This a very nice contribution, thanks a lot for this!

See two nits inline, otherwise LGTM.

docs/BitCodeFormat.rst
898 ↗(On Diff #74692)

Support will be preserved in 4.0 (and likely 5.0 and future, until we decide explicitly otherwise). See: http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility

1142 ↗(On Diff #74692)

(Same remark)

This revision is now accepted and ready to land.Oct 14 2016, 9:00 AM
ibadawi updated this revision to Diff 74702.Oct 14 2016, 9:29 AM
ibadawi edited edge metadata.

Update legacy notices to point to IR backwards compatibility policy.

ibadawi marked 2 inline comments as done.Oct 14 2016, 9:30 AM

I've updated the legacy notices with a reference to that backwards compatibility policy.

If this looks fine, can you commit it for me? I don't have commit access. Thanks!

This revision was automatically updated to reflect the committed changes.