This is an archive of the discontinued LLVM Phabricator instance.

[SE] Platforms return Device values
ClosedPublic

Authored by jhen on Sep 13 2016, 4:56 PM.

Details

Summary

Platforms were returning Device pointers, but a Device is now basically
just a pointer to an underlying PlatformDevice, so we will now just pass
it around as a value.

Diff Detail

Event Timeline

jhen updated this revision to Diff 71272.Sep 13 2016, 4:56 PM
jhen retitled this revision from to [SE] Platforms return Device values.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added subscribers: parallel_libs-commits, jprice.
jlebar accepted this revision.Sep 13 2016, 4:58 PM
jlebar edited edge metadata.

Perhaps it's worth a comment on the Device class that Device objects should be passed by value, and are cheap to copy?

This revision is now accepted and ready to land.Sep 13 2016, 4:58 PM
jhen updated this revision to Diff 71275.Sep 13 2016, 5:04 PM
jhen edited edge metadata.
  • Device doc says device is small
jhen added a comment.Sep 13 2016, 5:04 PM

Perhaps it's worth a comment on the Device class that Device objects should be passed by value, and are cheap to copy?

Good idea! Done

This revision was automatically updated to reflect the committed changes.