This is an archive of the discontinued LLVM Phabricator instance.

Differential D24306

Add test case for PR demonstrating C++ matching issue
AbandonedPublic

Authored by emaste on Sep 7 2016, 11:04 AM.

Details

Reviewers
grimar
Summary

If multiple mangled symbols produce identical demangled names it seems lld's version script handling only includes one of them.

For example both _ZN3abcC1Ev and _ZN3abcC2Ev should be abc::abc() but as seen with the addition in this patch only one of the two gets the symbol version appended:

Symbol {
  Name: _ZN3abcC1Ev@ (25)
  Value: 0x1003
  Size: 0
  Binding: Global (0x1)
  Type: Function (0x2)
  Other: 0
  Section: .text (0x6)
}
Symbol {
  Name: _ZN3abcC2Ev@@LIBSAMPLE_1.0 (37)
  Value: 0x1004
  Size: 0
  Binding: Global (0x1)
  Type: Function (0x2)
  Other: 0
  Section: .text (0x6)
}

Diff Detail

Revision Contents

PathSize
test/
ELF/
22 lines

Diff 70570

test/ELF/version-script-extern.s

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
# DSO-NEXT: Name: _ZN3abcC1Ev@@LIBSAMPLE_1.0 # DSO-NEXT: Name: _ZN3abcC1Ev@@LIBSAMPLE_1.0
# DSO-NEXT: Value: 0x1003 # DSO-NEXT: Value: 0x1003
# DSO-NEXT: Size: 0 # DSO-NEXT: Size: 0
# DSO-NEXT: Binding: Global (0x1) # DSO-NEXT: Binding: Global (0x1)
# DSO-NEXT: Type: Function (0x2) # DSO-NEXT: Type: Function (0x2)
# DSO-NEXT: Other: 0 # DSO-NEXT: Other: 0
# DSO-NEXT: Section: .text (0x6) # DSO-NEXT: Section: .text (0x6)
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol {
# DSO-NEXT: Name: _ZN3abcC2Ev@@LIBSAMPLE_1.0
# DSO-NEXT: Value: 0x1004
# DSO-NEXT: Size: 0
# DSO-NEXT: Binding: Global (0x1)
# DSO-NEXT: Type: Function (0x2)
# DSO-NEXT: Other: 0
# DSO-NEXT: Section: .text (0x6)
# DSO-NEXT: }
# DSO-NEXT: ] # DSO-NEXT: ]
# DSO-NEXT: Version symbols { # DSO-NEXT: Version symbols {
# DSO-NEXT: Section Name: .gnu.version # DSO-NEXT: Section Name: .gnu.version
# DSO-NEXT: Address: 0x240 # DSO-NEXT: Address: 0x258
# DSO-NEXT: Offset: 0x240 # DSO-NEXT: Offset: 0x258
# DSO-NEXT: Link: 1 # DSO-NEXT: Link: 1
# DSO-NEXT: Symbols [ # DSO-NEXT: Symbols [
# DSO-NEXT: Symbol { # DSO-NEXT: Symbol {
# DSO-NEXT: Version: 0 # DSO-NEXT: Version: 0
# DSO-NEXT: Name: @ # DSO-NEXT: Name: @
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol { # DSO-NEXT: Symbol {
# DSO-NEXT: Version: 3 # DSO-NEXT: Version: 3
# DSO-NEXT: Name: _Z3bari@@LIBSAMPLE_2.0 # DSO-NEXT: Name: _Z3bari@@LIBSAMPLE_2.0
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol { # DSO-NEXT: Symbol {
# DSO-NEXT: Version: 2 # DSO-NEXT: Version: 2
# DSO-NEXT: Name: _Z3fooi@@LIBSAMPLE_1.0 # DSO-NEXT: Name: _Z3fooi@@LIBSAMPLE_1.0
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol { # DSO-NEXT: Symbol {
# DSO-NEXT: Version: 2 # DSO-NEXT: Version: 2
# DSO-NEXT: Name: _Z3zedi@@LIBSAMPLE_1.0 # DSO-NEXT: Name: _Z3zedi@@LIBSAMPLE_1.0
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol { # DSO-NEXT: Symbol {
# DSO-NEXT: Version: 2 # DSO-NEXT: Version: 2
# DSO-NEXT: Name: _ZN3abcC1Ev@@LIBSAMPLE_1.0 # DSO-NEXT: Name: _ZN3abcC1Ev@@LIBSAMPLE_1.0
# DSO-NEXT: } # DSO-NEXT: }
# DSO-NEXT: Symbol {
# DSO-NEXT: Version: 2
# DSO-NEXT: Name: _ZN3abcC2Ev@@LIBSAMPLE_1.0
# DSO-NEXT: }
# DSO-NEXT: ] # DSO-NEXT: ]
# DSO-NEXT: } # DSO-NEXT: }
.text .text
.globl _Z3fooi .globl _Z3fooi
.type _Z3fooi,@function .type _Z3fooi,@function
_Z3fooi: _Z3fooi:
retq retq
.globl _Z3bari .globl _Z3bari
.type _Z3bari,@function .type _Z3bari,@function
_Z3bari: _Z3bari:
retq retq
.globl _Z3zedi .globl _Z3zedi
.type _Z3zedi,@function .type _Z3zedi,@function
_Z3zedi: _Z3zedi:
retq retq
.globl _ZN3abcC1Ev .globl _ZN3abcC1Ev
.type _ZN3abcC1Ev,@function .type _ZN3abcC1Ev,@function
_ZN3abcC1Ev: _ZN3abcC1Ev:
retq retq
.globl _ZN3abcC2Ev
.type _ZN3abcC2Ev,@function
_ZN3abcC2Ev:
retq