This is an archive of the discontinued LLVM Phabricator instance.

[SE] Don't pack raw device mem args
ClosedPublic

Authored by jhen on Sep 1 2016, 6:01 PM.

Details

Summary

Step 4 of getting GlobalDeviceMemory to own its handle.

Take out code to pack untyped device memory types as kernel arguments.
When GlobalDeviceMemory owns its handle, users will never touch untyped
device memory types, so they will never pass them as kernel args.

Diff Detail

Repository
rL LLVM

Event Timeline

jhen updated this revision to Diff 70120.Sep 1 2016, 6:01 PM
jhen retitled this revision from to [SE] Don't pack raw device mem args.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added subscribers: parallel_libs-commits, jprice.
jlebar accepted this revision.Sep 1 2016, 6:45 PM
jlebar edited edge metadata.
jlebar added inline comments.
streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp
104 ↗(On Diff #70120)

As a separate patch, I wonder if these classes should have a getByteCount() so you don't have to do this error-prone calculation.

This revision is now accepted and ready to land.Sep 1 2016, 6:45 PM
jhen added inline comments.Sep 2 2016, 9:18 AM
streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp
104 ↗(On Diff #70120)

Good idea. I'll do that.

This revision was automatically updated to reflect the committed changes.