This is an archive of the discontinued LLVM Phabricator instance.

[SE] Make Stream movable
ClosedPublic

Authored by jhen on Sep 1 2016, 9:48 AM.

Details

Summary

The example code makes it clear that this is a much better design
decision.

Diff Detail

Event Timeline

jhen updated this revision to Diff 70022.Sep 1 2016, 9:48 AM
jhen retitled this revision from to [SE] Make Stream movable.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added subscribers: parallel_libs-commits, jprice.
jlebar accepted this revision.Sep 1 2016, 9:52 AM
jlebar edited edge metadata.

Yeah, I like this better too.

streamexecutor/include/streamexecutor/Stream.h
344

No longer mutable

streamexecutor/lib/Stream.cpp
21

Nit, usually prefer make_unique so that it's clear that the destination variable is a unique_ptr.

This revision is now accepted and ready to land.Sep 1 2016, 9:52 AM
jhen updated this revision to Diff 70033.Sep 1 2016, 11:41 AM
jhen marked 2 inline comments as done.
jhen edited edge metadata.
  • Respond to jlebar's comments
streamexecutor/include/streamexecutor/Stream.h
344

Removed the comment

This revision was automatically updated to reflect the committed changes.