This is an archive of the discontinued LLVM Phabricator instance.

Fixup TestPyObjSynthProvider.py and enable it again
ClosedPublic

Authored by labath on Aug 31 2016, 5:28 AM.

Details

Summary
  • copies the new file in the cmake build
  • adds an additional import statement
  • marks the test as no-debug-info specific, as it seems to be testing a python feature

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 69836.Aug 31 2016, 5:28 AM
labath retitled this revision from to Fixup TestPyObjSynthProvider.py and enable it again.
labath updated this object.
labath added a reviewer: granata.enrico.
labath added a subscriber: lldb-commits.
granata.enrico accepted this revision.Aug 31 2016, 9:34 AM
granata.enrico edited edge metadata.
granata.enrico added inline comments.
packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
19 ↗(On Diff #69836)

I assume this only implies not to build for *all* debug info formats, but still allows an a.out to be built?

If so, fine by me

packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
3 ↗(On Diff #69836)

That didn't seem to be necessary on macOS. Not sure what the difference is, but anyway, doesn't look wrong.

This revision is now accepted and ready to land.Aug 31 2016, 9:34 AM
This revision was automatically updated to reflect the committed changes.
labath added inline comments.Aug 31 2016, 10:49 AM
packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
19 ↗(On Diff #69836)

Acknowledged.

packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
3 ↗(On Diff #69836)

Yes.. very odd, but it did not work without it for me.