This is an archive of the discontinued LLVM Phabricator instance.

[StreamExecutor] Add Platform and PlatformManager
ClosedPublic

Authored by jhen on Aug 24 2016, 4:01 PM.

Diff Detail

Event Timeline

jhen updated this revision to Diff 69181.Aug 24 2016, 4:01 PM
jhen retitled this revision from to [StreamExecutor] Add Platform and PlatformManager.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added subscribers: parallel_libs-commits, jprice.
jlebar accepted this revision.Aug 24 2016, 4:07 PM
jlebar edited edge metadata.
jlebar added inline comments.
streamexecutor/include/streamexecutor/Platform.h
34

Do we want to say here that ownership isn't transferred to the caller? I'm on the fence, maybe it's obvious.

This revision is now accepted and ready to land.Aug 24 2016, 4:07 PM
jhen updated this revision to Diff 69182.Aug 24 2016, 4:14 PM
jhen edited edge metadata.
  • Add comment about ownership
jhen added inline comments.Aug 24 2016, 4:16 PM
streamexecutor/include/streamexecutor/Platform.h
36

I'll stick a comment in for it. I think it's nice to have.

This revision was automatically updated to reflect the committed changes.