This is an archive of the discontinued LLVM Phabricator instance.

[StreamExecutor] Fix allocateDeviceMemory
ClosedPublic

Authored by jhen on Aug 24 2016, 12:45 PM.

Details

Summary

The return value from PlatformExecutor::allocateDeviceMemory needs to be
converted from Expected<GlobalDeviceMemoryBase> to
Expected<GlobalDeviceMemory<T>> in Executor::allocateDeviceMemory.

A similar bug is also fixed for Executor::allocateHostMemory.

Thanks to jprice for identifying this bug.

Diff Detail

Event Timeline

jhen updated this revision to Diff 69155.Aug 24 2016, 12:45 PM
jhen retitled this revision from to [StreamExecutor] Fix allocateDeviceMemory.
jhen updated this object.
jhen added reviewers: jprice, jlebar.
jhen added a subscriber: parallel_libs-commits.
jlebar accepted this revision.Aug 24 2016, 12:47 PM
jlebar edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 12:47 PM
This revision was automatically updated to reflect the committed changes.