Page MenuHomePhabricator

Add R_386_TLS_LE as a relocation having an implicit addend.
ClosedPublic

Authored by ed on Aug 20 2016, 2:08 AM.

Details

Summary

TLS on i386 in non-PIE/PIC code seems broken right now, because we don't
properly add the addend encoded in the instruction to the resulting
offset when processing R_386_TLS_LE relocations.

Extend one of the existing tests for TLS on i686 to use an addend.

Diff Detail

Repository
rL LLVM

Event Timeline

ed updated this revision to Diff 68769.Aug 20 2016, 2:08 AM
ed retitled this revision from to Add R_386_TLS_LE as a relocation having an implicit addend..
ed updated this object.
ed added reviewers: ruiu, rafael.
ruiu accepted this revision.Aug 20 2016, 3:44 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 20 2016, 3:44 AM
This revision was automatically updated to reflect the committed changes.