Page MenuHomePhabricator

Include X86CallFrameOptimization in the opt-bisect process
ClosedPublic

Authored by andrew.w.kaylor on Aug 18 2016, 11:40 AM.

Details

Summary

This patch updates the X86CallFrameOptimization in such a way that it can be skipped when using the -opt-bisect-limit option.

This pass was not included when I originally implemented this feature in the x86-specific passes (see D19439) because at that time it was being run at -O0. Since D22362 introduced a check to omit this pass at -O0 it can now also be included in the opt-bisect process.

The change I am making here will also cause this pass to be skipped for any function that has the opt-none function attribute.

Diff Detail

Repository
rL LLVM

Event Timeline

andrew.w.kaylor retitled this revision from to Include X86CallFrameOptimization in the opt-bisect process.
andrew.w.kaylor updated this object.
andrew.w.kaylor added reviewers: mkuper, rnk.
andrew.w.kaylor set the repository for this revision to rL LLVM.
andrew.w.kaylor added a subscriber: llvm-commits.
mkuper accepted this revision.Aug 18 2016, 11:47 AM
mkuper edited edge metadata.

Thanks Andy, LGTM!

This revision is now accepted and ready to land.Aug 18 2016, 11:47 AM
This revision was automatically updated to reflect the committed changes.