Page MenuHomePhabricator

[NFC][ObjC Availability] Split up DiagnoseAvailabilityOfDecl, remove redundant enumeration
ClosedPublic

Authored by erik.pilkington on Aug 5 2016, 1:23 PM.

Details

Summary

This patch removes the enum Sema::AvailabilityDiagnostic, which is redundant with clang::AvailabilityResult, and pulls out a function, ShouldDiagnoseAvailabiltyOfDecl from DiagnoseAvailabiltyOfDecl. This is so we can call ShouldDiagnoseAvailabilityOfDecl when emitting -Wunguarded-availabilty, which is done after Sema of a function.

This patch was originally part of https://reviews.llvm.org/D23003, but it was suggested that I separate it out.

Event Timeline

erik.pilkington retitled this revision from to [NFC][ObjC Availability] Split up DiagnoseAvailabilityOfDecl, remove redundant enumeration.
erik.pilkington updated this object.
erik.pilkington added a reviewer: manmanren.
erik.pilkington added a subscriber: cfe-commits.
manmanren accepted this revision.Aug 5 2016, 3:31 PM
manmanren edited edge metadata.

Thanks,
Manman

This revision is now accepted and ready to land.Aug 5 2016, 3:31 PM
This revision was automatically updated to reflect the committed changes.