This is an archive of the discontinued LLVM Phabricator instance.

Remove the Triple tests that were stressing the Parser's behaviour
ClosedPublic

Authored by jojo on Aug 4 2016, 12:18 AM.

Details

Reviewers
rengolin
Summary

Now the tests of TargetParser is in place:
unittests/Support/TargetParserTest.cpp.
So the tests in TripleTest.cpp which actually stressing on TargetParser's behavior could be removed.

Diff Detail

Event Timeline

jojo updated this revision to Diff 66765.Aug 4 2016, 12:18 AM
jojo retitled this revision from to Remove the Triple tests that were stressing the Parser's behaviour.
jojo updated this object.
jojo added a reviewer: rengolin.
jojo added a subscriber: llvm-commits.
rengolin accepted this revision.Aug 15 2016, 10:24 AM
rengolin edited edge metadata.

Excellent! This should rid us of some seconds on check-all, and all of those tests are now redundant, thanks to your new unit-tests.

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 15 2016, 10:24 AM
jojo closed this revision.Aug 16 2016, 11:39 PM

Committed r278899.