This is an archive of the discontinued LLVM Phabricator instance.

Fix incorrect form test in SymbolFileDWARF
ClosedPublic

Authored by labath on Jul 25 2016, 7:08 AM.

Details

Summary

We were checking whether an attribute is in block form by getting the block data pointer, which
was not correct as the pointer be null even if the attribute is in block form. Other places in
the file already use the correct test.

To make this work, I've needed to add DW_FORM_exprlock to the list of "block" forms, which seems
correct as that is how we are parsing it.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 65340.Jul 25 2016, 7:08 AM
labath retitled this revision from to Fix incorrect form test in SymbolFileDWARF.
labath updated this object.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
clayborg accepted this revision.Jul 25 2016, 10:39 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 25 2016, 10:39 AM
This revision was automatically updated to reflect the committed changes.