Page MenuHomePhabricator

Missing includes
ClosedPublic

Authored by CrisCristescu on Jun 27 2016, 9:45 AM.

Details

Summary

When building llvm self-hosted with modules there are some missing includes which prevent the modules to be built.

Diff Detail

Repository
rL LLVM

Event Timeline

CrisCristescu retitled this revision from to Missing includes.
CrisCristescu updated this object.
CrisCristescu added reviewers: v.g.vassilev, rsmith.
CrisCristescu set the repository for this revision to rL LLVM.
CrisCristescu added a project: Restricted Project.
rsmith accepted this revision.Jun 27 2016, 11:53 AM
rsmith edited edge metadata.

Assuming you've tested that these header files don't compile standalone without these changes, and do compile standalone with these changes, this LGTM.

This revision is now accepted and ready to land.Jun 27 2016, 11:53 AM
CrisCristescu edited edge metadata.

Correct diff.

v.g.vassilev closed this revision.Jun 28 2016, 5:24 AM
v.g.vassilev edited edge metadata.

Landed in r274004.