Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D21352

Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.
ClosedPublic
Actions

Authored by nlewycky on Jun 14 2016, 2:37 PM.

Details

Reviewers
george.burgess.iv
Summary

Point to the relevant 'nonnull' or 'returns_nonnull' attribute when complaining about 'a == 0' or 'f() == 0' expressions.

Diff Detail

Event Timeline

nlewycky updated this revision to Diff 60756.Jun 14 2016, 2:37 PM
nlewycky retitled this revision from to Add a "declared 'nonnull' here" note to warnings where an expression is checked against null..
nlewycky updated this object.
nlewycky added a subscriber: cfe-commits.
george.burgess.iv accepted this revision.Jun 14 2016, 5:53 PM
george.burgess.iv added a reviewer: george.burgess.iv.
george.burgess.iv added a subscriber: george.burgess.iv.

LGTM, thanks for the patch!

This revision is now accepted and ready to land.Jun 14 2016, 5:53 PM
nlewycky closed this revision.Jun 14 2016, 10:25 PM

Closed by r272755.

Revision Contents
Changeset List

PathSize
include/
clang/
Basic/
2 lines
lib/
Sema/
16 lines
test/
Sema/
10 lines

Diff 60756

View Options

include/clang/Basic/DiagnosticSemaKinds.td

Loading...
View Options

lib/Sema/SemaChecking.cpp

Loading...
View Options

test/Sema/nonnull.c

Loading...