This is an archive of the discontinued LLVM Phabricator instance.

Differential D21281

Fix a typo in loop versioning.
ClosedPublic

Authored by tvvikram on Jun 13 2016, 2:01 AM.

Details

Reviewers
ashutosh.nema
Commits
rG299abc10e709: Fix a typo in loop versioning.
rL272545: Fix a typo in loop versioning.

Diff Detail

Event Timeline

tvvikram updated this revision to Diff 60495.Jun 13 2016, 2:01 AM
tvvikram retitled this revision from to Fix a typo in loop versioning..
tvvikram updated this object.
tvvikram added a subscriber: llvm-commits.
tvvikram added a reviewer: ashutosh.nema.Jun 13 2016, 2:02 AM
ashutosh.nema accepted this revision.Jun 13 2016, 3:46 AM
ashutosh.nema edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jun 13 2016, 3:46 AM
tvvikram closed this revision.Jun 13 2016, 3:56 AM

Revision Contents

PathSize
lib/
Transforms/
Utils/
2 lines

Diff 60495

lib/Transforms/Utils/LoopVersioning.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Linesvoid LoopVersioning::versionLoop(
auto *CI = dyn_cast<ConstantInt>(SCEVRuntimeCheck); auto *CI = dyn_cast<ConstantInt>(SCEVRuntimeCheck);
// Discard the SCEV runtime check if it is always true. // Discard the SCEV runtime check if it is always true.
if (CI && CI->isZero()) if (CI && CI->isZero())
SCEVRuntimeCheck = nullptr; SCEVRuntimeCheck = nullptr;
if (MemRuntimeCheck && SCEVRuntimeCheck) { if (MemRuntimeCheck && SCEVRuntimeCheck) {
RuntimeCheck = BinaryOperator::Create(Instruction::Or, MemRuntimeCheck, RuntimeCheck = BinaryOperator::Create(Instruction::Or, MemRuntimeCheck,
SCEVRuntimeCheck, "ldist.safe"); SCEVRuntimeCheck, "lver.safe");
if (auto *I = dyn_cast<Instruction>(RuntimeCheck)) if (auto *I = dyn_cast<Instruction>(RuntimeCheck))
I->insertBefore(RuntimeCheckBB->getTerminator()); I->insertBefore(RuntimeCheckBB->getTerminator());
} else } else
RuntimeCheck = MemRuntimeCheck ? MemRuntimeCheck : SCEVRuntimeCheck; RuntimeCheck = MemRuntimeCheck ? MemRuntimeCheck : SCEVRuntimeCheck;
assert(RuntimeCheck && "called even though we don't need " assert(RuntimeCheck && "called even though we don't need "
"any runtime checks"); "any runtime checks");
▲ Show 20 Lines • Show All 226 Lines • Show Last 20 Lines