Page MenuHomePhabricator

[Basic] Change x86_64-windows-macho targets to use Windows-style va_lists.
Needs ReviewPublic

Authored by cdavis5x on May 19 2016, 1:52 PM.

Details

Reviewers
rsmith
Summary

This is a very strange target. Sema thinks it's targeting a Darwin-esque
system, while IRGen thinks it's targeting a Windows'ish system. The result
is that Clang can no longer compile __builtin_va_arg (either for a normal
or Win64 va_list) properly. So, for this target, explicitly set the
va_list kind to CharPtr, the same as Win64. This is what users expect,
anyway.

Fixes PR27663.

Diff Detail

Event Timeline

cdavis5x updated this revision to Diff 57855.May 19 2016, 1:52 PM
cdavis5x retitled this revision from to [Basic] Change x86_64-windows-macho targets to use Windows-style va_lists..
cdavis5x updated this object.
cdavis5x added a reviewer: rsmith.
cdavis5x added a subscriber: cfe-commits.

Extremely belated ping.