This is an archive of the discontinued LLVM Phabricator instance.

Fix TestEvents.py on OS X
ClosedPublic

Authored by tfiala on May 5 2016, 9:30 AM.

Details

Reviewers
jingham
Summary

This change addresses a hang/segfault in TestEvents.py. The threads that run the listener loops now do an SBListener.Clear() before they wrap up their work. This prevents the test from trying to clean up the SBListener too late.

There is a separate issue here which is that we should prevent this clean-up time lock-up, but that is out of scope for this particular change. I'd like to get these tests back and running the normal flow rather than skipping them.

This addresses:
llvm.org/pr25924 (at least, the OS X side, although I suspect this will also address Linux)

Diff Detail

Event Timeline

tfiala updated this revision to Diff 56301.May 5 2016, 9:30 AM
tfiala retitled this revision from to Fix TestEvents.py on OS X.
tfiala updated this object.
tfiala added a reviewer: jingham.
tfiala updated this object.
tfiala added a subscriber: lldb-commits.
tfiala updated this revision to Diff 56303.May 5 2016, 9:35 AM

Added full diff context to diff.

jingham accepted this revision.May 5 2016, 10:43 AM
jingham edited edge metadata.

I agree, doing something to get the test working is primary. Then we can go back and figure out why the less ordered shutdown doesn't work.

This revision is now accepted and ready to land.May 5 2016, 10:43 AM
tfiala closed this revision.May 5 2016, 10:55 AM

Closed by commit r268653