Page MenuHomePhabricator

SLSR: Use UnknownAddressSpace instead of default
ClosedPublic

Authored by arsenm on Apr 25 2016, 8:51 PM.

Details

Reviewers
jingyue
Summary

In the case where isLegalAddressingMode is used for cases
not related to addressing modes, such as pure adds and muls,
it should not be using address space 0. LSR already passes -1
as the address space in these cases.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 54964.Apr 25 2016, 8:51 PM
arsenm retitled this revision from to SLSR: Use UnknownAddressSpace instead of default.
arsenm updated this object.
arsenm added a reviewer: jingyue.
arsenm added a subscriber: llvm-commits.
jingyue accepted this revision.Apr 26 2016, 10:28 AM
jingyue edited edge metadata.

Maybe change the title to be "... instead of default for pure arithmetic instructions". Otherwise, LGTM!

This revision is now accepted and ready to land.Apr 26 2016, 10:28 AM
arsenm closed this revision.Apr 26 2016, 5:39 PM

r267645