This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ] Add compare-and-branch instructions to MC.
ClosedPublic

Authored by koriakin on Apr 3 2016, 7:21 AM.

Details

Summary

This adds MC support for fused compare + indirect branch instructions,
ie. CRB, CGRB, CLRB, CLGRB, CIB, CGIB, CLIB, CLGIB. They aren't actually
generated yet -- this is preparation for their use for conditional
returns in the next iteration of D17339.

Diff Detail

Repository
rL LLVM

Event Timeline

koriakin retitled this revision from to [SystemZ] Add compare-and-branch instructions to MC..
koriakin updated this object.
koriakin added a reviewer: uweigand.
koriakin set the repository for this revision to rL LLVM.
koriakin updated this object.Apr 3 2016, 7:24 AM
uweigand edited edge metadata.Apr 4 2016, 4:48 AM

Please also add disassembler tests for the new instructions to test/MC/Disassembler/SystemZ/insns.txt

Otherwise this looks good to me.

koriakin edited edge metadata.
uweigand accepted this revision.Apr 4 2016, 7:24 AM
uweigand edited edge metadata.

LGTM, thanks.

This revision is now accepted and ready to land.Apr 4 2016, 7:24 AM

Thanks. I have no commit access, how can I get this commited?

This revision was automatically updated to reflect the committed changes.

Thanks. I have no commit access, how can I get this commited?

I've checked this in for you now. Longer term, if you plan on making more contributions to LLVM, you might want to get SVN access yourself, as outlined here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access