Page MenuHomePhabricator

[NVVM] Remove noduplicate attribute from synchronizing intrinsics.
ClosedPublic

Authored by jlebar on Mar 14 2016, 5:38 PM.

Details

Summary

I've completed my audit of all the code that looks at noduplicate and
added handling of convergent where appropriate, so we no longer need
noduplicate on these intrinsics.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 50685.Mar 14 2016, 5:38 PM
jlebar retitled this revision from to [NVVM] Remove noduplicate attribute from synchronizing intrinsics..
jlebar updated this object.
jlebar added a reviewer: jholewinski.
jlebar added a subscriber: llvm-commits.

Friendly ping here -- I think we're ready to go with this one. It's necessary to get inlining of functions which contain syncthreads() and unrolling of loops that contain syncthreads(), so has a pretty substantial performance impact.

jingyue accepted this revision.Mar 22 2016, 12:01 PM
jingyue edited edge metadata.

Thanks for working on this long overdue feature!

This revision is now accepted and ready to land.Mar 22 2016, 12:01 PM
This revision was automatically updated to reflect the committed changes.