Page MenuHomePhabricator

[NVPTX] Disable performance optimizations when OptLevel==None
ClosedPublic

Authored by jingyue on Feb 3 2016, 6:08 PM.

Diff Detail

Event Timeline

jingyue updated this revision to Diff 46859.Feb 3 2016, 6:08 PM
jingyue retitled this revision from to [NVPTX] Disable performance optimizations when OptLevel==None.
jingyue updated this object.
jingyue added reviewers: eliben, jholewinski, tra.
jingyue added a subscriber: llvm-commits.
eliben accepted this revision.Feb 3 2016, 6:27 PM
eliben edited edge metadata.
eliben added inline comments.
lib/Target/NVPTX/NVPTXTargetMachine.cpp
146–147

Is EarlyCSE required for correctness? Might worth pointing out why it stays in non-opt mode

This revision is now accepted and ready to land.Feb 3 2016, 6:27 PM
jingyue updated this revision to Diff 46864.Feb 3 2016, 8:18 PM
jingyue marked an inline comment as done.
jingyue edited edge metadata.

More comments.

lib/Target/NVPTX/NVPTXTargetMachine.cpp
146–147

Added more comments. This function is only called in opt mode, so its behavior when OptLevel is None doesn't matter.

jingyue closed this revision.Feb 3 2016, 8:19 PM