This is an archive of the discontinued LLVM Phabricator instance.

Fix TestDataFormatterScript for Linux.
ClosedPublic

Authored by chaoren on Jan 28 2016, 6:37 PM.

Details

Summary

m_function_name will contain a dummy name for the auto-generated function from
the python script on Linux. Check for script name first.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 46330.Jan 28 2016, 6:37 PM
chaoren retitled this revision from to Fix TestDataFormatterScript for Linux..
chaoren updated this object.
chaoren added a reviewer: granata.enrico.
chaoren added a subscriber: lldb-commits.
This revision was automatically updated to reflect the committed changes.

That seems reasonable, yes.

In general, I wish I had done this not via two strings - only one of which gets to be valid in some arbitrary order - but via either two distinct subclasses, or at least via a pair of a string and an enum class specifying the kind.

But that is clearly beyond the scope of you fixing this test case. Your change is fine.