Page MenuHomePhabricator

Pass --wrap=pthread_create to linker for -fsplit-stack
ClosedPublic

Authored by hjl.tools on Jan 22 2016, 10:36 AM.

Details

Reviewers
rafael
rsmith
Summary

From

https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html

-fsplit-stack should pass --wrap=pthread_create to linker for -fsplit-stack
It is needed to initialize the stack guard. This fixes PR 20148.

Diff Detail

Event Timeline

hjl.tools updated this revision to Diff 45698.Jan 22 2016, 10:36 AM
hjl.tools retitled this revision from to Pass --wrap=pthread_create to linker for -fsplit-stack.
hjl.tools updated this object.
hjl.tools added a reviewer: rsmith.
hjl.tools added a subscriber: cfe-commits.

Needs a testcase.

hjl.tools updated this revision to Diff 45735.Jan 22 2016, 1:26 PM

Add a testcase.

rafael accepted this revision.Jan 25 2016, 10:07 AM
rafael added a reviewer: rafael.

LGTM

This revision is now accepted and ready to land.Jan 25 2016, 10:07 AM

Can you check it in for me? Thanks.