This is an archive of the discontinued LLVM Phabricator instance.

Differential D16309

Use getCharWidth() instead of magic number
AbandonedPublic

Authored by danielmarjamaki on Jan 18 2016, 11:52 PM.

Details

Reviewers
None
Summary

Use getCharWidth() instead of magic number to handle arbitrary char widths.

no change in logical behaviour is intended when getCharWidth() is 8.

Diff Detail

Event Timeline

danielmarjamaki updated this revision to Diff 45231.Jan 18 2016, 11:52 PM
danielmarjamaki retitled this revision from to Use getCharWidth() instead of magic number.
danielmarjamaki updated this object.
danielmarjamaki added a subscriber: cfe-commits.
danielmarjamaki added a comment.Feb 12 2016, 4:16 AM

ping

danielmarjamaki added a comment.Sep 19 2016, 7:09 AM

ping.

danielmarjamaki abandoned this revision.Sep 23 2016, 5:34 AM

Fixed by r282242

Revision Contents

PathSize
lib/
Frontend/
2 lines

Diff 45231

lib/Frontend/InitPreprocessor.cpp

Show First 20 Lines • Show All 638 Lines • ▼ Show 20 Lines#undef TOSTR2
if (TI.getPointerWidth(0) == 32 && TI.getLongWidth() == 32 if (TI.getPointerWidth(0) == 32 && TI.getLongWidth() == 32
&& TI.getIntWidth() == 32) { && TI.getIntWidth() == 32) {
Builder.defineMacro("_ILP32"); Builder.defineMacro("_ILP32");
Builder.defineMacro("__ILP32__"); Builder.defineMacro("__ILP32__");
} }
// Define type sizing macros based on the target properties. // Define type sizing macros based on the target properties.
assert(TI.getCharWidth() == 8 && "Only support 8-bit char so far"); assert(TI.getCharWidth() == 8 && "Only support 8-bit char so far");
Builder.defineMacro("__CHAR_BIT__", "8"); Builder.defineMacro("__CHAR_BIT__", Twine(TI.getCharWidth()));
DefineTypeSize("__SCHAR_MAX__", TargetInfo::SignedChar, TI, Builder); DefineTypeSize("__SCHAR_MAX__", TargetInfo::SignedChar, TI, Builder);
DefineTypeSize("__SHRT_MAX__", TargetInfo::SignedShort, TI, Builder); DefineTypeSize("__SHRT_MAX__", TargetInfo::SignedShort, TI, Builder);
DefineTypeSize("__INT_MAX__", TargetInfo::SignedInt, TI, Builder); DefineTypeSize("__INT_MAX__", TargetInfo::SignedInt, TI, Builder);
DefineTypeSize("__LONG_MAX__", TargetInfo::SignedLong, TI, Builder); DefineTypeSize("__LONG_MAX__", TargetInfo::SignedLong, TI, Builder);
DefineTypeSize("__LONG_LONG_MAX__", TargetInfo::SignedLongLong, TI, Builder); DefineTypeSize("__LONG_LONG_MAX__", TargetInfo::SignedLongLong, TI, Builder);
DefineTypeSize("__WCHAR_MAX__", TI.getWCharType(), TI, Builder); DefineTypeSize("__WCHAR_MAX__", TI.getWCharType(), TI, Builder);
DefineTypeSize("__INTMAX_MAX__", TI.getIntMaxType(), TI, Builder); DefineTypeSize("__INTMAX_MAX__", TI.getIntMaxType(), TI, Builder);
▲ Show 20 Lines • Show All 348 Lines • Show Last 20 Lines