This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add an override option for specifying the loader implementation
ClosedPublic

Authored by jhuber6 on Jul 20 2023, 6:32 AM.

Details

Summary

There are some cases when testing we want to override the logic for not
building tests if the loader is not present. This allows users to
specify an external binary that fulfils the same duties which will force
the tests to be built even without meeting the dependencies.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 20 2023, 6:32 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 20 2023, 6:32 AM
jhuber6 requested review of this revision.Jul 20 2023, 6:32 AM
JonChesterfield accepted this revision.Jul 20 2023, 6:39 AM

Works a charm. Tested as "-DLIBC_GPU_LOADER_EXECUTABLE=$HOME/GPU/amdhsa_loader", switches on the tests as hoped. Thanks!

This revision is now accepted and ready to land.Jul 20 2023, 6:39 AM
This revision was landed with ongoing or failed builds.Jul 20 2023, 6:45 AM
This revision was automatically updated to reflect the committed changes.