This is an archive of the discontinued LLVM Phabricator instance.

[libc++][tests] Fix a test testing wrong class
ClosedPublic

Authored by pfusik on Jul 15 2023, 2:17 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG34bd7e229d82: [libc++][tests] Fix a test testing wrong class

Diff Detail

Event Timeline

pfusik created this revision.Jul 15 2023, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 2:17 AM
pfusik requested review of this revision.Jul 15 2023, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 2:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

This is just a small test cleanup: the directory and header comment said that it tests stringstream but it used istringstream.
The test was originally created this way: https://github.com/llvm/llvm-project/commit/1347d334518a3642243e97c7d173452443047e2f#diff-ea0557985f856925f1b019fcd64ee6d1ff0465ad8cd19a42b355e5b9c97589fe

Mordante accepted this revision.Jul 15 2023, 6:42 AM
Mordante added a subscriber: Mordante.

Nice catch! LGTM!

This revision is now accepted and ready to land.Jul 15 2023, 6:42 AM
This revision was automatically updated to reflect the committed changes.